-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome on Windows: Cannot read properties of undefined (reading 'filter') #1823
Comments
Hello 👋 Thank you for taking the time to open this issue with floccus. I know it's frustrating when software One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum, I look forward to working with you on this issue |
I'm sorry about the trouble. This has been reported before this week in the following issue, #1814 So I'm going to close this issue in favor of that one. Important note: You just publicly shared the passphrase that you used to encrypt the bookmarks file as well as your Google Drive refresh token. :S I urgently recommend revoking access for Floccus to your Google Drive and not using the same encryption passphrase again. Feel free to comment here if you have more questions about this. |
Thanks for pointing that out. I figured it didn't matter because I planned
to uninstall the extension anyway. With that said, is there any way to
simply delete that file, considering that you closed my ticket anyway?
…On Sun, Jan 12, 2025, 3:22 AM Marcel Klehr ***@***.***> wrote:
Hi @GrantRobertson <https://github.com/GrantRobertson>
Important note: You just publicly shared the passphrase that you used to
encrypt the bookmarks file as well as your Google Drive refresh token. :S
—
Reply to this email directly, view it on GitHub
<#1823 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5W4HLZKWJ5VUGIW7QQUET2KIX7BAVCNFSM6AAAAABU7TI356VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVGY2TMMZSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@GrantRobertson I sadly cannot delete the file here on Github, I think. |
@marcelklehr I looked around and GitHub has now created a virtual assistant specifically for deleting attachments to issues. Here is the URL: https://support.github.com/?q=delete%20issue%20attachment&search_origin=%2Frequest Here is a StackOverflow thread on the topic: https://stackoverflow.com/questions/33215211/github-how-do-i-delete-an-attachment-in-github-issues/33215776#33215776 Of course, there is no guarantee that I didn't just signal some giant bot farm to start pouring through that file looking for things that can be used maliciously. But, we just accept that we live in a society, now don't we. To be clear: That Google Drive refresh token was just for your extension to use. Correct? You didn't store my whole Google drive access information in your configuration file, did you? (And no, that password is not my Google password. It was just a random encryption string, for your service.) |
The Google Drive refresh token can be used to create new files in your Google Drive, so I recommend revoking access to floccus. Removing the attachment is a bonus, I'd say, as once information is published it cannot be unpublished, philosophically speaking. |
It also seems you have to be the attachment uploader to delete it :/ Although I'm repo admin, I cannot delete it |
That makes sense. I have already used the virtual assistant. It told me that it issued a ticket to get the file deleted. Apparently, that still has to be done by humans. |
Apparently that file has already been deleted. I just tried to download it again, and got: But, who's to say what bots may have scraped that file in the short time that it existed. Can you tell me how to "revoke access to Floccus"? |
@marcelklehr I figured out how to revoke Floccus's access to my Google Drive. Apparently, the last thing I need to do is delete my account on Floccus. Not that I will never come back, but just to clean out any kruft, just in case. I can always come back later. I couldn't find a way to delete my account on Floccus.org. Is there a way you could delete that account from your servers? Thanks. |
This one's easy. There is no account on my servers :) It's only in your browser. If you remove the extension, everything is gone. |
Sweet!
Thanks.
If I try it again, later, I'll let you know how it goes.
…________________________________
From: Marcel Klehr ***@***.***>
Sent: Monday, January 13, 2025 11:06:38 AM
To: floccusaddon/floccus ***@***.***>
Cc: Grant S. Robertson ***@***.***>; Mention ***@***.***>
Subject: Re: [floccusaddon/floccus] Chrome on Windows: Cannot read properties of undefined (reading 'filter') (Issue #1823)
Is there a way you could delete that account from your servers?
This one's easy. There is no account on my servers :) It's only in your browser. If you remove the extension, everything is gone.
—
Reply to this email directly, view it on GitHub<#1823 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA5W4HI3MRWGLXVBWGQCRWD2KPXB5AVCNFSM6AAAAABU7TI356VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBXGY4TAMZSG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Which version of floccus are you using?
5.4.2
How many bookmarks do you have, roughly?
7461
Are you using other means to sync bookmarks in parallel to floccus?
no
Sync method
Google Drive
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Chrome
Which version of Nextcloud Bookmarks are you using? (if relevant)
No response
Which version of Nextcloud? (if relevant)
No response
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
It just can't seem to actually read my bookmarks.
I have attached the debug log file here:
floccus-5.4.2-2025-01-11-full.log
I couldn't really see any reason to redact anything.
Expected Behavior
For this first run, I just wanted to see if it would synchronize to the file in the correct location on my google drive. Note: it did not get to the phase where it actually creates the file on my Google Drive.
I noticed that there was no button to use a File Open window to select the correct folder in which to put the bookmarks.xbel file. So, I just manually entered the path, within the Google Drive, to put the file. As you can see in the following line from the .json file:
Should I have used the full pathname to the file? Or, should I have simply accepted the default location of being in the root of my Google Drive (not my preference)?
To Reproduce
Simply install the extension. I exited all instances of the Chrome browser and restarted so that the extension was sure to be running cleanly. I have exported the .json of the configuration and will attach it below, so you can see how I configured it. Maybe it was just something in my configuration.
floccus.export.json
Debug log provided
The text was updated successfully, but these errors were encountered: