-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "Default Rolluot" for Boolean to be false #2811
Comments
Hey @PlkMarudny the default value for a Boolean flag is just the enabled property of the flag. This works as you described here, where the flag returns false if all other conditions fail. |
@GeorgeMac |
Hey @anthonpetrow When it comes to Boolean flags, the enabled property (the toggle on the flag view) is the value returned when all other rollout conditions associated with a flag resolve to false. You can then add rollouts which change the resulting value of the flag to true (or false, you can do the reverse here too) under certain conditions (within some percentage rollout or when matching a segment). Does that help clarify? Another point which might help: you do not need to “enable” a Boolean flag to use it. You can still use a “disabled” flag, this just means the flags evaluates to false (ie disabled by default). |
@GeorgeMac I understand it can work with
|
@ducva I totally appreciate that. I agree that it is confusing that enabled is leveraged for the default here. When designing this, I did push against what you're describing as I felt (at the time) that having both enabled and default was more confusing than representing a boolean flag as just a single boolean value (e.g. like a remote boolean variable) that you could change the resulting value of based on conditions was cleaner (This was influenced by my past experience other feature flag tools that did it in this way). However, to get there, we already had models for representing the flag that we needed to fit this in, which meant co-opting Clearly this was a mistake and has left folks confused. I hold my hands up there 🙌 Now that we have this contract though, we can't change it out from under folks. Introducing The first, most backwards compatible things I can think of, would be to rework the wording so that the existing behaviour is more intentional and clear from the UI and API perspectives. For the boolean flag page view in the UI, we could simply change the wording of We could go a step further and introduce a These are couple relatively low touch changes that might make the existing experience clearer, what do you all think? We are totally open to suggestions though, if anyone has any, for backwards compatible changes here that could help in this area 🙏 |
Problem
It is a cosmetic issue maybe, but I would prefer to have bool flags to be set to 'false' by default and just enable them gradually, so whoever is not granted a feature it has is disabled. A new feature will be disabled until enabled then, this type of logic.
Ideal Solution
Allow to change the values of the "Default Rollout" for boolean flags from true to false.
Search
Additional Context
No response
The text was updated successfully, but these errors were encountered: