Update microel.c #4264
Draft
Update microel.c #4264
+379
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grugnoymeme
requested review from
DrZlo13,
gornekich,
gsurkov and
hedger
as code owners
hedger
requested changes
Sep 22, 2025
Member
hedger
left a comment
hedger
left a comment
There was a problem hiding this comment.
Please use English in code comments and variable names - for ease of further support.
Could you please provide a sample dump file to verify the parser?
|
|
||
| #define KEY_LENGTH 6 | ||
| #define UID_LENGTH 4 | ||
| // Offset per la conversione dell'anno (5 bit: da 0 a 31, quindi range 2010–2041) |
Member
There was a problem hiding this comment.
Please keep all comments in English
| } | ||
| } else { | ||
| //Key a is the same as sumHex | ||
| // KeyA uguale a sumHex |
| MfClassicKey key_default = {0}; | ||
| memcpy(key_default.data, keyF, sizeof(keyF)); | ||
|
|
||
| bool __attribute__((unused)) default_auth_works = false; |
| } | ||
|
|
||
| bool keys_found = false; | ||
| uint8_t chiaveA[6], chiaveB[6]; |
| void trea_calculateKeys( | ||
| const uint8_t* uid, | ||
| const uint8_t* codiceGestore, | ||
| uint8_t* chiaveA, |
| switch(service_indicator) { | ||
| case 0x04: | ||
| return "Autolavaggio"; | ||
| // Altri tipi da aggiungere con nuovi dump: |
hedger
added
NFC
Member
|
Please un-draft when fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
This update enhances the Microel card parser by adding support for extracting additional data fields from the Mifare Classic 1K card, including:
Basic card information:
UID
ATQA
SAK
Extended data fields:
Vendor ID
Available credit
Last transaction details
Transaction date
Operation number
Operation type
Admission credit
Deposit status (Yes/No)
Points balance
Previous credit amount
Date of previous credit
These additions improve the accuracy and completeness of the parsed data.
Checklist (For Reviewer)