Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: fixed grep arg for RC builds #3093

Merged
merged 4 commits into from
Sep 21, 2023
Merged

github: fixed grep arg for RC builds #3093

merged 4 commits into from
Sep 21, 2023

Conversation

hedger
Copy link
Member

@hedger hedger commented Sep 19, 2023 •
edited by skotopes
Loading

What's new

  • github: fixed grep arg for RC builds
  • fbt: allowed .git to be a file, not only a dir (useful with git worktrees and when being checked out as a submodule)

Verification

  • Marking RC SDKs as released should now work without warnings

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

Compiled f7 firmware for commit 8b02099e:

@skotopes skotopes merged commit b80dfbe into dev Sep 21, 2023
8 checks passed
@skotopes skotopes deleted the hedger/grepfix branch September 21, 2023 09:44
@hedger hedger added Bug Build System & Scripts fbt, scripts and toolchain-related labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

Assignees
No one assigned
Labels
Bug Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes