Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoLang based sharded client for DKV #40

Open
3 of 7 tasks
KalyanAkella opened this issue Mar 30, 2021 · 0 comments · Fixed by #43
Open
3 of 7 tasks

GoLang based sharded client for DKV #40

KalyanAkella opened this issue Mar 30, 2021 · 0 comments · Fixed by #43
Assignees
Labels
enhancement New feature or request

Comments

@KalyanAkella
Copy link
Contributor

KalyanAkella commented Mar 30, 2021

We currently have a GoLang client impl. inside dkv/pkg/ctl/client.go, but this implementation needs to be extended in the following ways in order to make it compatible with the Java based impl.

Specifically, this issue is about enhancing the existing GoLang client in the following ways:

  • extract the impl. into dkv/clients/go since that is where we intend to develop various DKV clients
  • this new location will be another independent GOROOT with its own go.mod and go.sum files + Makefile.
  • impl. support for clients-side sharding based on the Java client's impl.
  • for hashing, use the XXHash impl. for GoLang here
  • for caching/pooling GRPC connections, we can consider using ristretto
  • integrate with StatsD and provide metrics for latencies and errors.
  • build script changes to build GoLang client before building dkvctl, or perhaps we can choose to generate dkvctl directly from this GoLang client package itself
@KalyanAkella KalyanAkella added the enhancement New feature or request label Mar 30, 2021
@kingster kingster linked a pull request Apr 19, 2021 that will close this issue
@kingster kingster changed the title GoLang based client for DKV GoLang based sharded client for DKV Jun 30, 2021
@kingster kingster added this to the Beta Release v0.1 milestone Aug 3, 2022
@kingster kingster reopened this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants