Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests currently fail on M1, but not on Intel MacOS #18

Open
paddyroddy opened this issue Feb 14, 2022 · 4 comments
Open

Tests currently fail on M1, but not on Intel MacOS #18

paddyroddy opened this issue Feb 14, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@paddyroddy
Copy link

I have managed to get this to build on M1 (see here flimlib/flimlib#60 (comment)) but it only works if I force the tests to be skipped i.e. mvn clean install -DskipTests

The error message is here:
image

From googling around it looks like Failed to load class "org.slf4j.impl.StaticLoggerBinder" could be fixed by e.g. https://stackoverflow.com/a/9919375/7359333

My colleague @drmattews doesn't need to force the tests to fail on his Intel Mac (it appears to work out of the box) so the issue seems to be somewhat M1/Apple Silicon related

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/cmake-fails-to-build-on-m1-mac-apple-silicon/61964/8

@hinerm hinerm added the bug Something isn't working label Mar 5, 2024
@hinerm
Copy link

hinerm commented Mar 5, 2024

As of flimlib 2.1.1 I can confirm tests are still failing on arm64 macs. It looks like the numerical computation differs (slight rounding in most cases). My current failures are:

[ERROR] Failures: 
[ERROR]   FitTest.testBayesFitImg:151->assertSampleEquals:222 arrays first differed at element [2]; expected:<0.20058449> but was:<1164.4563>
[ERROR]   FitTest.testBinning:125->assertSampleEquals:222 arrays first differed at element [0]; expected:<15.917448> but was:<15.917488>
[ERROR]   FitTest.testGlobalFitImg:188->assertSampleEquals:222 arrays first differed at element [3]; expected:<4.498526> but was:<4.498537>
[ERROR]   FitTest.testRLDFitImg:115->assertSampleEquals:222 arrays first differed at element [3]; expected:<4.498526> but was:<4.498537>

@hinerm
Copy link

hinerm commented Mar 6, 2024

@paulbarber just wanted to bring you into this conversation. I assume this is an issue in core flimlib but it's obvious/easy to reproduce here in flimj-ops. We have not run these tests on a non-arm64 Mac yet, but they do pass on Windows.

@ctrueden
Copy link
Member

ctrueden commented Mar 6, 2024

As a next step, I'd like to see whether the tests fail also on Intel Macs, or only Apple Silicon machines. Either way though, we should try to minify this example to something that can be reproduced in flimlib alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants