Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

That the "parse" method defines a number callback prevents the integer and double callbacks from ever being invoked #12

Open
lehenbauer opened this issue Dec 5, 2013 · 0 comments

Comments

@lehenbauer
Copy link
Collaborator

From examining the yajl source and docs, if a non-null number callback function is defined in a yajl_callbacks structure and subsequently passed to yajltcl_make_parser, when the parser is used, the integer and double callbacks will never be invoked.

We should be able to change the number_callback in the "yajl_callbacks callbacks" structure definition to NULL and delete the number_callback function and gain a slight performance improvement in the "parse" method.

It's an easy fix but it could stand to be tested.

The parse2json method defines a number callback but does not define integer or double callbacks, so no change is needed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant