Skip to content

[Frontend] OS Settings on device page behind premium check despite not having any premium features #34801

@MatthewSH

Description

@MatthewSH

Fleet version: 4.75.1, Free tier


This is an extension of a conversation I had here: https://osquery.slack.com/archives/C01DXJL16D8/p1761564900161539?thread_ts=1761544588.918439&cid=C01DXJL16D8

For context, this is the only setting on the pricing page I can find about profiles or OS settings. So from what I can tell OS settings should be available on both settings everywhere. I could be wrong on this.

Image

Grey show this image as an example to see OS settings and where to click:

Image

However compare this to my, free, version:

Image

Besides obvious design differences, the main thing missing which I would expect in free is the "OS Settings." I expect this as free tier users can still apply profiles and use OS settings, limited.

This check is made here:
https://github.com/fleetdm/fleet/blob/main/frontend/pages/hosts/details/cards/HostSummary/HostSummary.tsx#L447,L460

{isOsSettingsDisplayPlatform(platform, os_version) &&
  isPremiumTier &&
  hostSettings &&
  hostSettings.length > 0 && (
    <DataSet
      title="OS settings"
      value={
        <OSSettingsIndicator
          profiles={hostSettings}
          onClick={toggleOSSettingsModal}
        />
      }
    />
)}

When diving through the requests made I ended up down to the MDMHostData struct which is populated here:

MDM MDMHostData `json:"mdm" db:"mdm_host_data" csv:"-"`

and defined here:

type MDMHostData struct {

From my understanding of the code, which I've only been poking around in since last night so I could be mistaken, this premium check does not make sense in this specific instance.

If this is indeed a bug, I'll be happy to just make a quick change and open a PR since it's a single line change.

Metadata

Metadata

Assignees

Labels

#g-mdmMDM product group:releaseReady to write code. Scheduled in a release. See "Making changes" in handbook.bugSomething isn't working as documented~frontendFrontend-related issue.~released bugThis bug was found in a stable release.

Type

No type

Projects

Status

✅ Ready for release

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions