Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11/26 UI updates #24173

Closed
2 tasks done
jacobshandling opened this issue Nov 26, 2024 · 3 comments
Closed
2 tasks done

11/26 UI updates #24173

jacobshandling opened this issue Nov 26, 2024 · 3 comments
Assignees
@jacobshandling
Labels
~frontend Frontend-related issue. P2 Prioritize as urgent :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.)
Milestone
4.60.0

Comments

@jacobshandling
Copy link
Contributor

jacobshandling commented Nov 26, 2024 •
edited
Loading

@jacobshandling jacobshandling added #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. labels Nov 26, 2024
@jacobshandling jacobshandling self-assigned this Nov 26, 2024
@jacobshandling jacobshandling added this to the 4.60.0 milestone Nov 26, 2024
@jacobshandling jacobshandling added ~frontend Frontend-related issue. P2 Prioritize as urgent labels Nov 26, 2024
@sharon-fdm sharon-fdm added the ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.) label Nov 26, 2024
@jacobshandling jacobshandling mentioned this issue Nov 26, 2024
Merged
1 task
jacobshandling added a commit that referenced this issue Nov 26, 2024
@jacobshandling
UI – 11/26 Disk encryption spec updates (#24175)
ea9b5ba 
## #24173 

<img width="1390" alt="Screenshot 2024-11-26 at 11 08 25 AM"
src="https://github.com/user-attachments/assets/3afc7031-2bac-4cc9-ac8d-e47390a0ef93">
<img width="1392" alt="Screenshot 2024-11-26 at 10 45 11 AM"
src="https://github.com/user-attachments/assets/2eccc992-e0bd-4c5c-b001-75cde60317b5">

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
jacobshandling added a commit that referenced this issue Nov 26, 2024
@jacobshandling
UI – 11/26 Disk encryption spec updates (#24175)
471ab76 
## #24173 

<img width="1390" alt="Screenshot 2024-11-26 at 11 08 25 AM"
src="https://github.com/user-attachments/assets/3afc7031-2bac-4cc9-ac8d-e47390a0ef93">
<img width="1392" alt="Screenshot 2024-11-26 at 10 45 11 AM"
src="https://github.com/user-attachments/assets/2eccc992-e0bd-4c5c-b001-75cde60317b5">

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
@xpkoala
Copy link
Contributor

xpkoala commented Nov 27, 2024

The fixes look good.

One note that the updated banner Disk encryption: Disk encryption is off. Currently, to turn on full disk encryption, the end user has to re-install their operating system. does not appear on the my device page for the user. I'm not sure if this is expected or not.

The banner displayed on the my device page is the "Disk encryption: Follow the instructions in the guide..." messaging with a linkout to fleetdm.com/learn-more-about/encrypt-linux-device

@iansltx
Copy link
Member

iansltx commented Nov 27, 2024

My Device page should be unchanged. Host details is the only page with revisions here.

@fleet-release
Copy link
Contributor

Tooltip guides like stars,
In the cloud city, banners shine,
Ease for Linux minds.

@sharon-fdm sharon-fdm removed the #g-endpoint-ops Endpoint ops product group label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobshandling jacobshandling

Labels
~frontend Frontend-related issue. P2 Prioritize as urgent :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.)
Projects
None yet
Milestone
4.60.0
Development

No branches or pull requests
6 participants
@iansltx @lukeheath @xpkoala @jacobshandling @fleet-release @sharon-fdm