diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ea6aba776515..8ddd9b8aedc8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,6 +10,10 @@ If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features. - [ ] Added/updated tests +- [ ] If database migrations are included, checked table schema to confirm autoupdate +- For database migrations: + - [ ] Checked schema for all modified table for columns that will auto-update timestamps during migration. + - [ ] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [ ] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [ ] Manual QA must be performed in the three main OSs, macOS, Windows and Linux.