Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build testscanner.exe on Linux #81

Open
perezmeyer opened this issue Nov 10, 2015 · 3 comments
Open

Can't build testscanner.exe on Linux #81

perezmeyer opened this issue Nov 10, 2015 · 3 comments

Comments

@perezmeyer
Copy link

This is exactly #63 except that for Linux. I just removed the WIN32 stanzas in the patch that solved the aforementioned issue and it worked.

Considering the patch I think this is actually a bug while building shared libraries.
@drizt
Copy link
Contributor

drizt commented Nov 10, 2015

Please provide compilation log.

drizt referenced this issue in drizt/qjson Nov 10, 2015
@drizt
cmake: fixed tests compilation on Windows
b09bf9c
@perezmeyer
Copy link
Author

Hi Drizt! As Kevin noted in the commit the reason is we distros do use -fvisibility=hidden -fvisibility-inlines-hidden in our CXXFLAGS, so symbols no explicitely exposed are hidden. The resulting compilation log is the same as in the Windows case in #63.

@drizt
Copy link
Contributor

drizt commented Nov 11, 2015

Ok. Then drop WIN32 stanza and send pull request.I think it will be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@perezmeyer @drizt