Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak-node-generator does not work well with lockfile v3 in monorepo #366

Open
G-Ray opened this issue Aug 30, 2023 · 1 comment
Open

Comments

@G-Ray
Copy link

G-Ray commented Aug 30, 2023

flatpak-builder version

1.3.3

Linux distribution and version

Fedora 38

Affected flatpak-builder tool

node/flatpak-node-generator.py

flatpak-builder tool cli args

No response

Source repository URL

https://github.com/G-Ray/pikatorrent

Flatpak-builder manifest URL

https://github.com/G-Ray/flathub/blob/pikatorrent-build-from-sources/com.github.G_Ray.pikatorrent.yml

Description

Trying to generate sources with flatpak-node-generator npm ./package-lock.json (lockfile v3) in a monorepo project results in only a few dependencies written.

example with https://github.com/G-Ray/pikatorrent:

3957 packages read.
Generating packages [3957/3957] randombytes @ 2.1.0                                                     
Wrote 226 source(s)

Meanwhile, if I convert the lockfile to v2:

1983 packages read.
Generating packages [1983/1983] @tamagui/label @ 1.55.2                                                 
Wrote 6968 source(s)
@almereyda
Copy link

This is confirmed. Regenerating a v2 lockfile with npm i --lockfile-version 2 --package-lock-only helped for all dependencies to be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants