Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed end-of-life runtime error. #27

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Conversation

guylamar2006
Copy link
Contributor

No description provided.

@guylamar2006 guylamar2006 marked this pull request as draft October 24, 2024 18:46
@flathubbot
Copy link

Started test build 156754

@flathubbot
Copy link

Build 156754 failed

@flathubbot
Copy link

Started test build 156764

@flathubbot
Copy link

Build 156764 failed

@flathubbot
Copy link

Started test build 156766

@flathubbot
Copy link

Build 156766 failed

@flathubbot
Copy link

Started test build 156784

@flathubbot
Copy link

Build 156784 failed

@flathubbot
Copy link

Started test build 156929

@flathubbot
Copy link

Build 156929 failed

@PhilipK PhilipK marked this pull request as ready for review October 26, 2024 16:54
@PhilipK
Copy link
Collaborator

PhilipK commented Oct 27, 2024

Thanks for doing this!
It seems the build is failing as the linter gets mad about some of the finish-arguments permissions.

From what I can read, we can get around that by making a new file in the repo:
.flatpak-builder/lint-ignore.json

With the following content:

{
"ignored-issues": [
"finish-args-unnecessary-xdg-data-flatpak-ro-access",
"finish-args-unnecessary-xdg-data-lutris-ro-access",
"finish-args-unnecessary-xdg-data-Steam-rw-access"
]
}

@PhilipK
Copy link
Collaborator

PhilipK commented Oct 27, 2024

Thanks for doing this! It seems the build is failing as the linter gets mad about some of the finish-arguments permissions.

From what I can read, we can get around that by making a new file in the repo: .flatpak-builder/lint-ignore.json

With the following content:

{ "ignored-issues": [ "finish-args-unnecessary-xdg-data-flatpak-ro-access", "finish-args-unnecessary-xdg-data-lutris-ro-access", "finish-args-unnecessary-xdg-data-Steam-rw-access" ] }

Well turns out no, exceptions are granted on a case by case basis: https://docs.flathub.org/docs/for-app-authors/linter#exceptions

Problem is, this app really does need these permissions, but I understand why they by default think it is a bad idea.

@PhilipK
Copy link
Collaborator

PhilipK commented Oct 27, 2024

I made a pull request for exceptions here:
flathub-infra/flatpak-builder-lint#516

@flathubbot
Copy link

Started test build 157158

@flathubbot
Copy link

Build 157158 failed

@flathubbot
Copy link

Started test build 157172

@flathubbot
Copy link

Build 157172 failed

@flathubbot
Copy link

Started test build 157173

@flathubbot
Copy link

Build 157173 failed

@guylamar2006
Copy link
Contributor Author

@PhilipK

error[E0282]: type annotations needed for Box<_>
--> /run/build/boilr/cargo/vendor/time-0.3.21/src/format_description/parse/mod.rs:83:9
|
83 | let items = format_items
| ^^^^^
...
86 | Ok(items.into())
| ---- type must be known at this point
|
= note: this is an inference error on crate time caused by an API change in Rust 1.80.0; update time to version >=0.3.35 by calling cargo update

@PhilipK
Copy link
Collaborator

PhilipK commented Oct 28, 2024

@PhilipK

error[E0282]: type annotations needed for Box<_> --> /run/build/boilr/cargo/vendor/time-0.3.21/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | = note: this is an inference error on crate time caused by an API change in Rust 1.80.0; update time to version >=0.3.35 by calling cargo update

On it:
PhilipK/BoilR#415

@PhilipK
Copy link
Collaborator

PhilipK commented Oct 28, 2024

@guylamar2006 alright, new version of BoilR with all dependencies updated. This means that the commit hash needs to be updated and since there are new dependencies the cargo-lock file also needs updated.
The hash needs updated here:

commit: b33d965f227fe971fd590cb022f608521b506ef3

The new hash is the newest commit on the BoilR repo, this is it: 10caa7bee196922cc3f9df1354cc3516b89fa515
The updated cargo-lock file can be found here: https://raw.githubusercontent.com/PhilipK/BoilR/refs/heads/main/flatpak/cargo-lock.json
Just copy paste it into this PR.

Let me know if you need help with it.

@guylamar2006
Copy link
Contributor Author

@PhilipK I sent the new commit id hash and cargo-lock.json both as commits.

@PhilipK
Copy link
Collaborator

PhilipK commented Oct 28, 2024

@guylamar2006 Cool, i will merge as soon as the build is done.

@guylamar2006
Copy link
Contributor Author

@PhilipK buildbot never triggered when I sent the new commits.

@PhilipK
Copy link
Collaborator

PhilipK commented Oct 28, 2024

@guylamar2006 I can see that the build is still pending, so just wait it out, some times it takes a long time.

@PhilipK
Copy link
Collaborator

PhilipK commented Oct 28, 2024

@guylamar2006 don't you can see this but: https://buildbot.flathub.org/#/buildrequests/632803

@flathubbot
Copy link

Started test build 157343

@flathubbot
Copy link

Build 157343 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/140434/io.github.philipk.boilr.flatpakref

@PhilipK PhilipK merged commit d1bb579 into flathub:master Oct 28, 2024
1 check passed
@guylamar2006 guylamar2006 deleted the patch-1 branch October 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants