From 8431ba14845cddb14dbef45c98dcae9c375cec8f Mon Sep 17 00:00:00 2001
From: Davide Iadeluca <146922689+DavideIadeluca@users.noreply.github.com>
Date: Tue, 19 Nov 2024 17:57:49 +0100
Subject: [PATCH] [1.x] chore(core, tags): resolve `a11y` warnings in Admin
 Frontend (#4114)

* chore: add accessible label to scope removal button

* chore: add accessible label to edit tag button
---
 js/src/admin/components/TagsPage.js | 7 ++++++-
 locale/en.yml                       | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/js/src/admin/components/TagsPage.js b/js/src/admin/components/TagsPage.js
index 4564869b..54611b4f 100644
--- a/js/src/admin/components/TagsPage.js
+++ b/js/src/admin/components/TagsPage.js
@@ -16,7 +16,12 @@ function tagItem(tag) {
       <div className="TagListItem-info">
         {tagIcon(tag)}
         <span className="TagListItem-name">{tag.name()}</span>
-        <Button className="Button Button--link" icon="fas fa-pencil-alt" onclick={() => app.modal.show(EditTagModal, { model: tag })} />
+        <Button
+          className="Button Button--link"
+          icon="fas fa-pencil-alt"
+          aria-label={app.translator.trans('flarum-tags.admin.tags.edit_tag_label', { tag: tag.name() })}
+          onclick={() => app.modal.show(EditTagModal, { model: tag })}
+        />
       </div>
       {!tag.isChild() && tag.position() !== null && (
         <ol className="TagListItem-children TagList">
diff --git a/locale/en.yml b/locale/en.yml
index 3890539d..bb44b2a7 100644
--- a/locale/en.yml
+++ b/locale/en.yml
@@ -56,6 +56,7 @@ flarum-tags:
       about_tags_text: "Tags are used to categorize discussions. Primary tags are like traditional forum categories: they can be arranged in a two-level hierarchy. Secondary tags do not have hierarchy or order, and are useful for micro-categorization."
       create_primary_tag_button: Create Primary Tag
       create_secondary_tag_button: Create Secondary Tag
+      edit_tag_label: Edit Tag {tag}
       primary_heading: Primary Tags
       secondary_heading: Secondary Tags
       settings_heading: Settings