Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: structs as cel env var #13

Merged
merged 4 commits into from
Jul 21, 2023
Merged

fix: structs as cel env var #13

merged 4 commits into from
Jul 21, 2023

Conversation

adityathebe
Copy link
Member

No description provided.

@adityathebe
Copy link
Member Author

@adityathebe
Copy link
Member Author

This doesn't seem to work because the env can also contain durations which cannot be JSON marshalled

@moshloop
Copy link
Member

@adityathebe - can we not selectively go through the environment and convert only structs to maps, leaving the native types, time and duration as is ?

template.go Outdated Show resolved Hide resolved
@moshloop moshloop merged commit bfa135a into main Jul 21, 2023
5 checks passed
@adityathebe adityathebe deleted the fix/cel-env-json branch December 15, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants