Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main packages can't export symbols #13

Open
adamdecaf opened this issue Dec 26, 2019 · 1 comment
Open

main packages can't export symbols #13

adamdecaf opened this issue Dec 26, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@adamdecaf
Copy link

Describe the bug

Fixmie reported that an exported symbol in a main package needs a godoc comment, however main packages don't export symbols.

To Reproduce

See: https://github.com/moov-io/customers/pull/61/files/3bc77f07e60fff8b598cda9695ec3131f19057f3#diff-cb34cba271ca44e00fbbf4dc193e950b

Expected behavior

No PR comment about this issue.
@fatih
Copy link
Member

fatih commented Dec 26, 2019

Hi @adamdecaf

Thanks for the bug report. This is a good point. I'll make sure to fix it in upcoming releases. Thank you.

@fatih fatih added the bug Something isn't working label Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamdecaf @fatih