Avoid rounding of ticket and SLA metrics to match UI reports (#204)

* drafting

* docs

* make breaking and add rounding

* postgres bk

* cast as numeric before rounding

* numerics

* changelog

* prep for official release

* Q2 FY26 Automatic Package Updates (#205)

* Q2 FY26: Apply automated update.

* Q2 FY26: Update auto-release workflow only.

---------

Co-authored-by: fivetran-catfritz <[email protected]>
Co-authored-by: Jamie Rodriguez <[email protected]>

* how does this look

* add different versions

* changelog

* catherine feedback

* Generate dbt docs via GitHub Actions

* Update integration_tests/dbt_project.yml

Co-authored-by: fivetran-catfritz <[email protected]>

* Generate dbt docs via GitHub Actions

---------

Co-authored-by: Fivetran Maintainer Bot <[email protected]>
Co-authored-by: fivetran-catfritz <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: 4 people

.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md

@@ -12,13 +12,15 @@ Before marking this PR as "ready for review":
 
 ## PR Overview 
 **Package version introduced in this PR:** 
- 
+- 
+
 **This PR addresses the following Issue/Feature(s):**
 <!-- Add Issue # or internal ticket reference -->
+- 
 
 **Summary of changes:**  
 <!-- 1-2 sentences describing PR changes. -->
-
+- 
 
 ### Submission Checklist  
 - [ ] Alignment meeting with the reviewer (if needed)  
@@ -27,9 +29,10 @@ Before marking this PR as "ready for review":
   - [ ] **Validation Steps:** Check for unintentional effects (e.g., add/run consistency & integrity tests)
   - [ ] **Testing Instructions:** Confirm the change addresses the issue(s)
   - [ ] **Focus Areas:** Complex logic or queries that need extra attention  
+- [ ] Merge any relevant open PRs into this PR
 
 ### Changelog  
 <!-- Recommend drafting changelog notes, then refining via ChatGPT using:  
 "Draft a changelog entry based on the following notes." -->
 - [ ] Draft changelog for PR  
-- [ ] Final changelog for release review
+- [ ] Final changelog for release review

.github/workflows/auto-release.yml

@@ -3,11 +3,12 @@ on:
   pull_request:
     types:
       - closed
-    branches:
-      - main
+      - labeled
 
 jobs:
-  call-workflow-passing-data:
-    if: github.event.pull_request.merged
+  release:
+    if: |
+      (github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'main') ||
+      github.event.label.name == 'pre-release'
     uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
-    secrets: inherit
+    secrets: inherit

.github/workflows/generate-docs.yml

@@ -0,0 +1,13 @@
+name: 'generate dbt docs'
+on:
+  pull_request:
+    types:
+      - labeled
+
+jobs:
+  generate-docs:
+    if: github.event.label.name == 'docs:ready'
+    uses: fivetran/dbt_package_automations/.github/workflows/generate-docs.yml@main
+    secrets: inherit
+    with:
+      schema_var_name: zendesk_schema

.gitignore

@@ -1,7 +1,73 @@
-env/
-target/
+# dbt
+**/package-lock.yml
+package-lock.yml
+.dbt/
 dbt_modules/
+dbt_packages/
 logs/
+profiles.yml
+target/
+*.log
+
+# IDE files
+.idea/
+.vscode/
+*~
+*.swp
+*.swo
+
+# Jupyter Notebook
+.ipynb_checkpoints
+
+# OS generated files
+**/.DS_Store
 .DS_Store
-dbt_packages/
-package-lock.yml
+.Spotlight-V100
+.Trashes
+._*
+Thumbs.db
+ehthumbs.db
+
+# Python
+*.egg
+*.egg-info/
+*.py[cod]
+*.so
+*$py.class
+.Python
+__pycache__/
+build/
+develop-eggs/
+dist/
+downloads/
+eggs/
+.env
+.installed.cfg
+lib/
+lib64/
+MANIFEST
+parts/
+sdist/
+var/
+wheels/
+
+# Secrets and credentials
+.env.*
+.secrets
+credentials.json
+service-account.json
+
+# Temporary files
+.cache/
+*.temp
+*.tmp
+
+# Virtual environments
+.conda/
+.env
+.venv
+ENV/
+env/
+env.bak/
+venv/
+venv.bak/

CHANGELOG.md

@@ -1,3 +1,54 @@
+# dbt_zendesk v0.25.0
+
+## Schema/Data Changes
+
+**2 total changes • 2 possible breaking changes**
+| **Data Model/Column** | **Change type** | **Old** | **New** | **Notes** |
+| -------------- | --------------- | ------------ | ------------ | --------- |
+| [`zendesk__ticket_metrics`](https://fivetran.github.io/dbt_zendesk/#!/model/model.zendesk.zendesk__ticket_metrics)<br>• `first_resolution_business_minutes`<br>• `first_reply_time_business_minutes`<br>• `agent_wait_time_in_business_minutes`<br>• `requester_wait_time_in_business_minutes`<br>• `solve_time_in_business_minutes`<br>• `agent_work_time_in_business_minutes`<br>• `on_hold_time_in_business_minutes`<br>• `new_status_duration_in_business_minutes`<br>• `open_status_duration_in_business_minutes`<br>• `first_reply_time_calendar_minutes`<br>• `total_reply_time_calendar_minutes`<br>• `ticket_unassigned_duration_calendar_minutes`<br>• `requester_last_login_age_minutes`<br>• `assignee_last_login_age_minutes`<br>• `unsolved_ticket_age_minutes`<br>• `unsolved_ticket_age_since_update_minutes` | Column Data Type | Integer | Numeric rounded to four decimal places | Removed logic casting ticket metric values as integers in intermediate models. This may have caused minor rounding discrepancies between the Zendesk data models and UI reports. ([PR #204](https://github.com/fivetran/dbt_zendesk/pull/204)) |
+| [`zendesk__sla_policies`](https://fivetran.github.io/dbt_zendesk/#!/model/model.zendesk.zendesk__sla_policies)<br>• `sla_elapsed_time` | Data Type | Integer | Numeric rounded to four decimal places | May particularly affect `agent_work_time`, `first_reply_time`, `next_reply_time`, and `requester_wait_time` SLA policy metrics. ([PR #204](https://github.com/fivetran/dbt_zendesk/pull/204)) |
+
+### Under the Hood
+
+[PR #205](https://github.com/fivetran/dbt_zendesk/pull/205) includes the following updates:
+
+- Updated conditions in `.github/workflows/auto-release.yml`.
+- Added `.github/workflows/generate-docs.yml`.
+- Added `+docs: show: False` to `integration_tests/dbt_project.yml`.
+- Migrated `flags` (e.g., `send_anonymous_usage_stats`, `use_colors`) from `sample.profiles.yml` to `integration_tests/dbt_project.yml`.
+- Updated `maintainer_pull_request_template.md` with improved checklist.
+- Updated `.gitignore` to exclude additional DBT, Python, and system artifacts.
+
+# dbt_zendesk v0.25.0-a1
+
+[PR #204](https://github.com/fivetran/dbt_zendesk/pull/204) includes the following updates:
+
+## Bug Fixes
+- Removes logic casting ticket metric values as integers in intermediate models. This may have caused minor rounding discrepancies between the Zendesk data models and UI reports. 
+  - This may impact the following fields in the `zendesk__ticket_metrics` model, which will now be **numerics** rounded to the fourth decimal place:
+    - `first_resolution_business_minutes`
+    - `full_resolution_business_minutes`
+    - `first_reply_time_business_minutes`
+    - `agent_wait_time_in_business_minutes`
+    - `requester_wait_time_in_business_minutes`
+    - `solve_time_in_business_minutes`
+    - `agent_work_time_in_business_minutes`
+    - `on_hold_time_in_business_minutes`
+    - `new_status_duration_in_business_minutes`
+    - `open_status_duration_in_business_minutes`
+    - `first_reply_time_calendar_minutes`
+    - `total_reply_time_calendar_minutes`
+    - `ticket_unassigned_duration_calendar_minutes`
+    - `requester_last_login_age_minutes`
+    - `assignee_last_login_age_minutes`
+    - `unsolved_ticket_age_minutes`
+    - `unsolved_ticket_age_since_update_minutes`
+  - Particularly for the following SLA policy metrics, this may impact `zendesk__sla_policies.sla_elapsed_time`, which is also now a **numeric** rounded to the fourth decimal place:
+    - `agent_work_time`
+    - `first_reply_time`
+    - `next_reply_time`
+    - `requester_wait_time`
+
 # dbt_zendesk v0.24.2
 
 This release includes the following updates:

README.md

@@ -68,7 +68,7 @@ Include the following zendesk package version in your `packages.yml` file:
 ```yml
 packages:
   - package: fivetran/zendesk
-    version: [">=0.24.0", "<0.25.0"]
+    version: [">=0.25.0", "<0.26.0"]
 ```
 > **Note**: Do not include the Zendesk Support source package. The Zendesk Support transform package already has a dependency on the source in its own `packages.yml` file.
 
@@ -119,7 +119,7 @@ sources:
     database: <database_name>
     loader: fivetran
     loaded_at_field: _fivetran_synced
-      
+
     freshness: # feel free to adjust to your liking
       warn_after: {count: 72, period: hour}
       error_after: {count: 168, period: hour}
@@ -276,7 +276,7 @@ models:
   zendesk_source:
     +schema: my_new_schema_name # leave blank for just the target_schema
 ```
-    
+
 #### Change the source table references
 If an individual source table has a different name than the package expects, add the table name as it appears in your destination to the respective variable:
 
@@ -292,14 +292,14 @@ vars:
 ### (Optional) Step 6: Orchestrate your models with Fivetran Transformations for dbt Core™
 <details><summary>Expand for details</summary>
 <br>
-    
+
 Fivetran offers the ability for you to orchestrate your dbt project through [Fivetran Transformations for dbt Core™](https://fivetran.com/docs/transformations/dbt). Learn how to set up your project for orchestration through Fivetran in our [Transformations for dbt Core setup guides](https://fivetran.com/docs/transformations/dbt#setupguide).
 </details>
 
 ## Does this package have dependencies?
 This dbt package is dependent on the following dbt packages. These dependencies are installed by default within this package. For more information on the following packages, refer to the [dbt hub](https://hub.getdbt.com/) site.
 > IMPORTANT: If you have any of these dependent packages in your own `packages.yml` file, we highly recommend that you remove them from your root `packages.yml` to avoid package version conflicts.
-    
+
 ```yml
 packages:
     - package: fivetran/zendesk_source

dbt_project.yml

@@ -1,5 +1,5 @@
 name: 'zendesk'
-version: '0.24.2'
+version: '0.25.0'
 
 config-version: 2
 require-dbt-version: [">=1.3.0", "<2.0.0"]

docs/catalog.json

@@ -1,7 +1,7 @@
 config-version: 2
 
 name: 'zendesk_integration_tests'
-version: '0.24.2'
+version: '0.25.0'
 
 profile: 'integration_tests'
 
@@ -30,9 +30,9 @@ vars:
     zendesk_ticket_chat_event_identifier:      "ticket_chat_event_data"
 
   ## Uncomment for docs generation
-  # zendesk__unstructured_enabled: True
-  # using_ticket_chat: true
-  # using_audit_log: true
+  # zendesk__unstructured_enabled: True # @docs-include
+  # using_ticket_chat: true # @docs-include
+  # using_audit_log: true # @docs-include
 
   # For validation testing. To be commented out before release.
   # using_domain_names: false
@@ -48,6 +48,8 @@ models:
   +schema: "zendesk_{{ var('directed_schema','dev') }}"
 
 seeds:
+  +docs:
+    show: False
   +quote_columns: "{{ true if target.type == 'redshift' else false }}"
   zendesk_integration_tests:
     +column_types:
@@ -175,4 +177,5 @@ dispatch:
     search_order: ['spark_utils', 'dbt_utils']
 
 flags:
-  send_anonymous_usage_stats: False
+  send_anonymous_usage_stats: False
+  use_colors: True