Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first and last day columns for the general ledger model #79

Open
2 of 4 tasks
caffeinebounce opened this issue Apr 4, 2023 · 1 comment
Open
2 of 4 tasks

first and last day columns for the general ledger model #79

caffeinebounce opened this issue Apr 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@caffeinebounce
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

I think it would be a good idea to add the 'period last day', and 'period first day' columns to the GL table.

I find it more efficient/useful to work from the GL table, as opposed to the GL by period table, so I have the detail/drill through. Since most reporting is done on a monthly basis and the Profit and Loss model is currently all rolled up to the period_first_day, I think it would be a helpful feature to just have these columns included in the GL as it allows for easier reporting.

Describe alternatives you've considered

I am currently just adding the column myself in snowflake, when I push to our production database

CREATE OR REPLACE TABLE GL AS
SELECT *,
DATE_TRUNC('MONTH', TRANSACTION_DATE) AS PERIOD_FIRST_DAY,
CASE WHEN LAST_DAY(TRANSACTION_DATE) = TRANSACTION_DATE THEN TRANSACTION_DATE
ELSE LAST_DAY(TRANSACTION_DATE)
END AS PERIOD_LAST_DAY
FROM (SELECT *
FROM PC_FIVETRAN_DB.QUICKBOOKS_QUICKBOOKS.QUICKBOOKS__GENERAL_LEDGER
WHERE 1=0);

INSERT INTO GL

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@caffeinebounce caffeinebounce added the enhancement New feature or request label Apr 4, 2023
@elanfivetran
Copy link

Hey @caffeinebounce, thank you for your engagement in our Quickbooks package!

I just wanted to make sure I understand your request properly. To confirm, are you requesting that we add two additional columns to our quickbooks__general_ledger model -- one that is the first day of the month of the transaction and one that is the last day of the month of the transaction?

@fivetran-reneeli fivetran-reneeli self-assigned this May 15, 2024
@fivetran-reneeli fivetran-reneeli linked a pull request May 15, 2024 that will close this issue
7 tasks
@fivetran-reneeli fivetran-reneeli removed a link to a pull request May 15, 2024
7 tasks
@fivetran-reneeli fivetran-reneeli removed their assignment May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants