Skip to content

Commit e5711b2

Browse files
fivetran-catfritzfivetran-data-model-botgithub-actions[bot]fivetran-joemarkiewicz
authored
bug/microcurrency-rounding-reddit-ads (#156)
* bug/microcurrency-rounding-reddit-ads * Q2 FY26 Automatic Package Updates (#154) * Q2 FY26: Apply automated update. * Update generate-docs.yml * Update generate-docs.yml * Update generate-docs.yml * Update generate-docs.yml * Update generate-docs.yml * Generate dbt docs via GitHub Actions * Update generate-docs.yml * Update dbt_project.yml * Update dbt_project.yml * Generate dbt docs via GitHub Actions * Q2 FY26: Update auto-release workflow only. * Update CHANGELOG.md --------- Co-authored-by: fivetran-catfritz <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * changelog * changelog * Update CHANGELOG.md * changelog * Update README.md (#128) Co-authored-by: fivetran-catfritz <[email protected]> * Update README.md Co-authored-by: Joe Markiewicz <[email protected]> * Generate dbt docs via GitHub Actions * Update packages.yml --------- Co-authored-by: Fivetran Maintainer Bot <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joe Markiewicz <[email protected]>
1 parent a5614e3 commit e5711b2

File tree

13 files changed

+511
-405
lines changed

13 files changed

+511
-405
lines changed

.buildkite/pipeline.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ steps:
33
key: "run-dbt-postgres"
44
plugins:
55
- docker#v3.13.0:
6-
image: "python:3.8"
6+
image: "python:3.10.13"
77
shell: [ "/bin/bash", "-e", "-c" ]
88
environment:
99
- "BASH_ENV=/tmp/.bashrc"
@@ -18,7 +18,7 @@ steps:
1818
key: "run_dbt_snowflake"
1919
plugins:
2020
- docker#v3.13.0:
21-
image: "python:3.8"
21+
image: "python:3.10.13"
2222
shell: [ "/bin/bash", "-e", "-c" ]
2323
environment:
2424
- "BASH_ENV=/tmp/.bashrc"
@@ -35,7 +35,7 @@ steps:
3535
key: "run_dbt_bigquery"
3636
plugins:
3737
- docker#v3.13.0:
38-
image: "python:3.8"
38+
image: "python:3.10.13"
3939
shell: [ "/bin/bash", "-e", "-c" ]
4040
environment:
4141
- "BASH_ENV=/tmp/.bashrc"
@@ -47,7 +47,7 @@ steps:
4747
key: "run_dbt_redshift"
4848
plugins:
4949
- docker#v3.13.0:
50-
image: "python:3.8"
50+
image: "python:3.10.13"
5151
shell: [ "/bin/bash", "-e", "-c" ]
5252
environment:
5353
- "BASH_ENV=/tmp/.bashrc"
@@ -62,7 +62,7 @@ steps:
6262
key: "run_dbt_databricks"
6363
plugins:
6464
- docker#v3.13.0:
65-
image: "python:3.8"
65+
image: "python:3.10.13"
6666
shell: [ "/bin/bash", "-e", "-c" ]
6767
environment:
6868
- "BASH_ENV=/tmp/.bashrc"

.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,15 @@ Before marking this PR as "ready for review":
1212

1313
## PR Overview
1414
**Package version introduced in this PR:**
15-
15+
-
16+
1617
**This PR addresses the following Issue/Feature(s):**
1718
<!-- Add Issue # or internal ticket reference -->
19+
-
1820

1921
**Summary of changes:**
2022
<!-- 1-2 sentences describing PR changes. -->
21-
23+
-
2224

2325
### Submission Checklist
2426
- [ ] Alignment meeting with the reviewer (if needed)
@@ -27,9 +29,10 @@ Before marking this PR as "ready for review":
2729
- [ ] **Validation Steps:** Check for unintentional effects (e.g., add/run consistency & integrity tests)
2830
- [ ] **Testing Instructions:** Confirm the change addresses the issue(s)
2931
- [ ] **Focus Areas:** Complex logic or queries that need extra attention
32+
- [ ] Merge any relevant open PRs into this PR
3033

3134
### Changelog
3235
<!-- Recommend drafting changelog notes, then refining via ChatGPT using:
3336
"Draft a changelog entry based on the following notes." -->
3437
- [ ] Draft changelog for PR
35-
- [ ] Final changelog for release review
38+
- [ ] Final changelog for release review

.github/workflows/auto-release.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ on:
33
pull_request:
44
types:
55
- closed
6-
branches:
7-
- main
6+
- labeled
87

98
jobs:
10-
call-workflow-passing-data:
11-
if: github.event.pull_request.merged
9+
release:
10+
if: |
11+
(github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'main') ||
12+
github.event.label.name == 'pre-release'
1213
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
13-
secrets: inherit
14+
secrets: inherit

.github/workflows/generate-docs.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
name: 'generate dbt docs'
2+
on:
3+
pull_request:
4+
types:
5+
- labeled
6+
7+
jobs:
8+
generate-docs:
9+
if: github.event.label.name == 'docs:ready'
10+
uses: fivetran/dbt_package_automations/.github/workflows/generate-docs.yml@main
11+
secrets: inherit
12+
with:
13+
# This needs to be kept a long list like this, and ': public' should not be included in the last var of the list.
14+
schema_var_name: "amazon_ads_schema: 'public', apple_search_ads_schema: 'public', facebook_ads_schema: 'public', google_ads_schema: 'public', linkedin_ads_schema: 'public', microsoft_ads_schema: 'public', pinterest_schema: 'public', reddit_ads_schema: 'public', snapchat_ads_schema: 'public', tiktok_ads_schema: 'public', twitter_ads_schema"

.gitignore

Lines changed: 69 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,73 @@
1-
2-
target/
1+
# dbt
2+
**/package-lock.yml
3+
package-lock.yml
4+
.dbt/
35
dbt_modules/
6+
dbt_packages/
47
logs/
8+
profiles.yml
9+
target/
10+
*.log
11+
12+
# IDE files
13+
.idea/
14+
.vscode/
15+
*~
16+
*.swp
17+
*.swo
18+
19+
# Jupyter Notebook
20+
.ipynb_checkpoints
21+
22+
# OS generated files
23+
**/.DS_Store
524
.DS_Store
6-
venv
7-
dbt_packages/
25+
.Spotlight-V100
26+
.Trashes
27+
._*
28+
Thumbs.db
29+
ehthumbs.db
30+
31+
# Python
32+
*.egg
33+
*.egg-info/
34+
*.py[cod]
35+
*.so
36+
*$py.class
37+
.Python
38+
__pycache__/
39+
build/
40+
develop-eggs/
41+
dist/
42+
downloads/
43+
eggs/
44+
.env
45+
.installed.cfg
46+
lib/
47+
lib64/
48+
MANIFEST
49+
parts/
50+
sdist/
51+
var/
52+
wheels/
53+
54+
# Secrets and credentials
55+
.env.*
56+
.secrets
57+
credentials.json
58+
service-account.json
59+
60+
# Temporary files
61+
.cache/
62+
*.temp
63+
*.tmp
64+
65+
# Virtual environments
66+
.conda/
67+
.env
68+
.venv
69+
ENV/
870
env/
9-
integration_tests/package-lock.yml
10-
package-lock.yml
11-
integration_tests/.DS_Store
71+
env.bak/
72+
venv/
73+
venv.bak/

CHANGELOG.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,22 @@
1+
# dbt_ad_reporting v1.17.0
2+
[PR #156](https://github.com/fivetran/dbt_ad_reporting/pull/156) includes the following updates:
3+
4+
## Schema & Data Updates - Reddit Ads
5+
**17 total changes • 17 possible breaking changes**
6+
7+
| Data Models | Change Type | Old | New | Notes |
8+
| --- | --- | --- | --- | --- |
9+
| `ad_reporting__account_report` <br> `ad_reporting__ad_group_report` <br> `ad_reporting__ad_report` <br> `ad_reporting__campaign_report` <br> `ad_reporting__monthly_campaign_country_report` <br> `ad_reporting__url_report` <br> `reddit_ads__account_report` <br> `reddit_ads__ad_group_report` <br> `reddit_ads__ad_report` <br> `reddit_ads__campaign_country_report` <br> `reddit_ads__campaign_report` <br> `reddit_ads__url_report` <br> `stg_reddit_ads__account_report` <br> `stg_reddit_ads__ad_group_report` <br> `stg_reddit_ads__ad_report` <br> `stg_reddit_ads__campaign_country_report` <br> `stg_reddit_ads__campaign_report` | Column datatype | `spend` (`INT`) | `spend` (`NUMERIC`) | Updated the datatype of the `spend` field from `INT` to `NUMERIC` to preserve decimal precision and prevent rounding when converting to dollars. The type cast is applied in the Reddit Ads staging layer and propagates through to the transform layer. See the [dbt_reddit_ads v0.7.0 release](https://github.com/fivetran/dbt_reddit_ads_source/releases/tag/v0.7.0) for more details. |
10+
11+
## Under the Hood
12+
- Updated conditions in `.github/workflows/auto-release.yml`.
13+
- Added `.github/workflows/generate-docs.yml`.
14+
- Migrated `flags` (e.g., `send_anonymous_usage_stats`, `use_colors`) from `sample.profiles.yml` to `integration_tests/dbt_project.yml`.
15+
- Updated `maintainer_pull_request_template.md` with improved checklist.
16+
- Refreshed README tag block.
17+
- Updated Python image version to `3.10.13` in `pipeline.yml`.
18+
- Updated `.gitignore` to exclude additional DBT, Python, and system artifacts.
19+
120
# dbt_ad_reporting v1.16.0
221
[PR #153](https://github.com/fivetran/dbt_ad_reporting/pull/153) includes the following updates:
322

README.md

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,14 @@
55
href="https://github.com/fivetran/dbt_ad_reporting/blob/main/LICENSE">
66
<img src="https://img.shields.io/badge/License-Apache%202.0-blue.svg" /></a>
77
<a alt="dbt-core">
8-
<img src="https://img.shields.io/badge/dbt_Core™_version->=1.6.0_<2.0.0-orange.svg" /></a>
8+
<img src="https://img.shields.io/badge/dbt_Core™_version->=1.3.0_,<2.0.0-orange.svg" /></a>
99
<a alt="Maintained?">
1010
<img src="https://img.shields.io/badge/Maintained%3F-yes-green.svg" /></a>
1111
<a alt="PRs">
1212
<img src="https://img.shields.io/badge/Contributions-welcome-blueviolet" /></a>
13+
<a alt="Fivetran Quickstart Compatible"
14+
href="https://fivetran.com/docs/transformations/dbt/quickstart">
15+
<img src="https://img.shields.io/badge/Fivetran_Quickstart_Compatible%3F-yes-green.svg" /></a>
1316
</p>
1417

1518
## What does this dbt package do?
@@ -104,14 +107,14 @@ Include the following github package version in your `packages.yml`
104107
```yaml
105108
packages:
106109
- package: fivetran/ad_reporting
107-
version: [">=1.16.0", "<1.17.0"] # we recommend using ranges to capture non-breaking changes automatically
110+
version: [">=1.17.0", "<1.18.0"] # we recommend using ranges to capture non-breaking changes automatically
108111
```
109112

110113
Do NOT include the individual ad platform packages in this file. The ad reporting package itself has dependencies on these packages and will install them as well.
111114

112-
113115
### Step 3: Configure Database and Schema Variables
114-
By default, this package looks for your ad platform data in your target database. If this is not where your app platform data is stored, add the relevant `<connection>_database` variables to your `dbt_project.yml` file (see below).
116+
By default, this package looks for your ad platform data in your target database. If this is not where your app platform data is stored, add the relevant `<connector>_database` variables to your `dbt_project.yml` file (see below).
117+
> Please note, cross-database querying, where the `*_database` variable differs from the database specified in your `profiles.yml`, is not supported by all dbt adapters (e.g., dbt-redshift). Refer to the documentation for your specific destination adapter for more details on its capabilities.
115118

116119
```yml
117120
vars:
@@ -141,7 +144,7 @@ vars:
141144
142145
snapchat_schema: snapchat_ads
143146
snapchat_database: your_database_name
144-
147+
145148
tiktok_ads_schema: tiktok_ads
146149
tiktok_ads_database: your_database_name
147150
@@ -256,12 +259,12 @@ models:
256259
+schema: apple_search_ads
257260
apple_search_ads_source:
258261
+schema: apple_search_ads_source
259-
262+
260263
facebook_ads:
261264
+schema: facebook_ads
262265
facebook_ads_source:
263266
+schema: facebook_ads_source
264-
267+
265268
google_ads:
266269
+schema: google_ads
267270
google_ads_source:
@@ -291,12 +294,12 @@ models:
291294
+schema: snapchat_ads
292295
snapchat_ads_source:
293296
+schema: snapchat_ads_source
294-
297+
295298
tiktok_ads:
296299
+schema: tiktok_ads
297300
tiktok_ads_source:
298301
+schema: tiktok_ads_source
299-
302+
300303
twitter_ads:
301304
+schema: twitter_ads
302305
twitter_ads_source:
@@ -592,7 +595,7 @@ vars:
592595
#### Change the source table references
593596
If an individual source table has a different name than the package expects, add the table name as it appears in your destination to the respective variable. This is not available for sources in which you are unioning together multiple connections.
594597
> IMPORTANT: See the Apple Store [`dbt_project.yml`](https://github.com/fivetran/dbt_apple_store_source/blob/main/dbt_project.yml) and Google Play [`dbt_project.yml`](https://github.com/fivetran/dbt_google_play_source/blob/main/dbt_project.yml) variable declarations to see the expected names.
595-
598+
596599
```yml
597600
vars:
598601
<default_source_table_name>_identifier: your_table_name
@@ -670,7 +673,7 @@ packages:
670673
671674
- package: fivetran/amazon_ads
672675
version: [">=0.5.0", "<0.6.0"]
673-
676+
674677
- package: fivetran/amazon_ads_source
675678
version: [">=0.5.0", "<0.6.0"]
676679
@@ -679,13 +682,13 @@ packages:
679682
680683
- package: fivetran/apple_search_ads_source
681684
version: [">=0.6.0", "<0.7.0"]
682-
685+
683686
- package: fivetran/facebook_ads
684687
version: [">=0.10.0", "<0.11.0"]
685688
686689
- package: fivetran/facebook_ads_source
687690
version: [">=0.10.0", "<0.11.0"]
688-
691+
689692
- package: fivetran/google_ads
690693
version: [">=0.13.0", "<0.14.0"]
691694
@@ -711,10 +714,10 @@ packages:
711714
version: [">=0.13.0", "<0.14.0"]
712715
713716
- package: fivetran/reddit_ads
714-
version: [">=0.6.0", "<0.7.0"]
717+
version: [">=0.7.0", "<0.8.0"]
715718
716719
- package: fivetran/reddit_ads_source
717-
version: [">=0.6.0", "<0.7.0"]
720+
version: [">=0.7.0", "<0.8.0"]
718721
719722
- package: fivetran/snapchat_ads
720723
version: [">=0.10.0", "<0.11.0"]

dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'ad_reporting'
2-
version: '1.16.0'
2+
version: '1.17.0'
33

44
config-version: 2
55

docs/catalog.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/manifest.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)