-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoiding merge conflicts caused by not gitignoring database #111
Comments
@jelaniwoods This should maybe go into |
@raghubetina I don't understand when would a merge even occur in the student's git workflow? Since we do save the |
@jelaniwoods Yes, I believe checking out other branches shouldn't cause any issues. (Although I feel like I have noticed some "Pending migration" situations when I jump back and forth between branches, which I was hoping to avoid by ungitignoring It's true that we currently landed upon a merge-free workflow, with |
@raghubetina okay that makes sense. I assume then a |
@raghubetina according to the
These approaches seem mostly equivalent to me. Am overlooking something? |
@jelaniwoods In the past we relied on GitHub's built-in merging UI, and I was hoping to continue to do so; I don't relish the idea of building a UI for resolving conflicts, although I suppose it wouldn't be too bad. (We could perhaps build-in a button for "Merge" that greys out when it detects that it's not a fast-forward merge, and suggests to push to GitHub and handle it there in that case.) I would like students to
I thought that defining a |
OH, okay. I will investigate with GitHub's merge to see if if will accept the strategy. |
@raghubetina after a little research and testing, it doesn't appear that GItHub respects This SO answer further suggests that GitHub doesn't look at the file https://stackoverflow.com/a/24382933/10481804 |
@jelaniwoods What happens when you have conflicts in a binary file during GitHub merge? Does it let you pick one or the other, or does it just fail? |
@raghubetina In the PR I tested with the conflict of |
@jelaniwoods Blergh. I wonder how good Gitpod's built-in git UI is for merging. |
@raghubetina If it's local merging we can use Trying to merge without |
I've always worried about the tradeoff between:
Is this a potential solution?
https://stackoverflow.com/questions/15232000/git-ignore-files-during-merge
If so, we should consider including an appropriate
.gitattribute
file in all projects.The text was updated successfully, but these errors were encountered: