Fix large cluster operations, update dependencies and version to 1.5 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThadHouse
force-pushed
the
fixlargecluster
branch
from
4f10d8e
to
1b08d7b
Compare
ThadHouse
changed the title
|
@auscompgeek I had to integrate my takeover for #30 into this PR directly. Both updating the dependencies, and the fix here touched the exact same functionality, so splitting them wasn't possible. Also, the dependency update is a breaking change (It was in #30 too), but the type is only exported for the derive macros, so I'm not sure we actually care. Also, I want to make one more change that will also touch this area before an update gets published, but its a bit more, so probably worth doing as a separate PR. But I'd wait to publish until I get that one in as well. |
|
FYI I just tested the integration tests on a real roboRIO and they passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All reads of 4 bytes or less from the FPGA are treated as a u32 read, even if less bytes are read. The value for this is then shifted to fit in the number of bytes actually read by the u8 array read call.
However, any register bigger then 4 bytes isn't treated as a u32 read, but instead an actual array of u8s. This means that for clusters bigger then 4 bytes, we don't have to shift the bits going into the bitset.
Writes have the same issue and are solved the same way.
Closes #22
Because updating dependencies also involves touching this area (it changes how the arrays are turned into bit slices), I'm combining these 2 PR's rather than making 2 separate ones that completely interfere with each other.
Technically, this is a breaking change, because the type exported for FpgaBits changed in a breaking way, due to the dependency updating from pre-release to release. However, this is only exported in order to use from the derive macros, and we don't use any of the functionality that breaks.