Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing unified string optional values cause errors during marker filtering #5109

Open
fqueze opened this issue Sep 4, 2024 · 10 comments · May be fixed by #5125
Open

Missing unified string optional values cause errors during marker filtering #5109

fqueze opened this issue Sep 4, 2024 · 10 comments · May be fixed by #5125
Labels
bug Very important to fix, typically this means that the tool is broken or lying good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task markers Anything to do with marker data structures, marker chart, or the marker table

Comments

@fqueze
Copy link
Contributor

fqueze commented Sep 4, 2024 •
edited by data-sync-user
Loading

When changing the filter string nothing is visibly changing in the marker chart, but when sharing the profile and loading it in a new tab, this error is displayed in the marker chart: Error: index undefined not in UniqueStringArray.

Example profile: https://share.firefox.dev/3yVvZvZ

Julien said on Matrix:

we could check for undefined after

profiler/src/profile-logic/marker-schema.js

Line 673 in 662dc4a

let value = data[payloadField.key];

┆Issue is synchronized with this Jira Task
@julienw julienw added bug Very important to fix, typically this means that the tool is broken or lying help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task markers Anything to do with marker data structures, marker chart, or the marker table good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work labels Sep 4, 2024
@itsarijitray
Copy link

itsarijitray commented Sep 5, 2024 •
edited
Loading

can I give it a shot? @fqueze

@fqueze
Copy link
Contributor Author

fqueze commented Sep 10, 2024

can I give it a shot? @fqueze

Sure, go ahead :). (@julienw marked the issue as good first issue so I expect him to reply; sorry for the delay)

@julienw
Copy link
Contributor

julienw commented Sep 11, 2024

Yes sure go ahead ;-)

@itsarijitray itsarijitray linked a pull request Sep 14, 2024 that will close this issue
Open
@itsarijitray
Copy link

@julienw @fqueze Added a small null check.

#5125

@arpit-ayeeee
Copy link

Hi, is this issue open to contribute? I went thru the last pr against it, will that work? I would like to give it a shot.

@julienw
Copy link
Contributor

julienw commented Sep 29, 2024

Hi @arpit-ayeeee , as far as I know @itsarijitray is still working on it .
Also I'd like to highlight just in case you're part of outreachy that this project isn't an outreachy project.

@itsarijitray
Copy link

@julienw @fqueze @arpit-ayeeee

Apologies for the delay in my response. I am in the middle of an medical emergency so I am not able to work on this. @julienw you can assign this to @arpit-ayeeee as I am not sure if I will be able to allocate time at moment. Extremely sorry for the delay in my response.

@arpit-ayeeee
Copy link

Hi @julienw , should I make the requested changes?

@julienw
Copy link
Contributor

julienw commented Oct 18, 2024 •
edited
Loading

Please @arpit-ayeeee , if you're still up to it! :-)
@itsarijitray hope it will get better for you soon!

@julienw
Copy link
Contributor

julienw commented Nov 6, 2024

@arpit-ayeeee could you work on it finally? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Very important to fix, typically this means that the tool is broken or lying good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task markers Anything to do with marker data structures, marker chart, or the marker table
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Null checks to handle Missing unified string optional values itsarijitray/profiler
4 participants
@julienw @fqueze @itsarijitray @arpit-ayeeee