Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit the profile name is hard-coded in English #5094

Open
flodolo opened this issue Aug 26, 2024 · 4 comments
Open

Edit the profile name is hard-coded in English #5094

flodolo opened this issue Aug 26, 2024 · 4 comments
Labels
help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task i18n All things related to internationalization (incl. localization)

Comments

@flodolo
Copy link
Contributor

flodolo commented Aug 26, 2024

Code here:

const title = 'Edit the profile name';

@julienw julienw added bug Very important to fix, typically this means that the tool is broken or lying help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task i18n All things related to internationalization (incl. localization) labels Aug 26, 2024
@PratikThoratNortheastern

Hey I would like to help but before proceeding can you tell me why the change is mandatory and what changes do you expect? Just asking so I can infer better and come up with a solution catering to your needs

@julienw
Copy link
Contributor

julienw commented Aug 26, 2024

The goal is to localize the title attribute (in both button and input) as well as the aria-label attribute in the input.

Here is an example of localizing an attribute:

AppHeader--github-icon =
.title = Go to our Git repository (this opens in a new window)
used in
<Localized id="AppHeader--github-icon" attrs={{ title: true }}>

Please edit only the en-US locale, not the other ones.

Thanks!

@unamdev0
Copy link

unamdev0 commented Sep 1, 2024

Hi @PratikThoratNortheastern, are you working on this?
If not can I work on this?

@PratikThoratNortheastern

I have not been assigned this task yet.

@mstange mstange removed the bug Very important to fix, typically this means that the tool is broken or lying label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task i18n All things related to internationalization (incl. localization)
Projects
None yet
Development

No branches or pull requests

6 participants
@julienw @mstange @flodolo @unamdev0 @PratikThoratNortheastern and others