Write logs for all action types except indexer and embedder

Author: bryanatkinson

js/plugins/google-cloud/src/telemetry/action.ts

@@ -31,53 +31,46 @@ class ActionTelemetry implements Telemetry {
     logInputAndOutput: boolean,
     projectId?: string
   ): void {
-    if (!logInputAndOutput) {
-      return;
-    }
     const attributes = span.attributes;
-    const actionName = (attributes['genkit:name'] as string) || '<unknown>';
     const type = attributes['genkit:type'] as string;
-    const subtype = attributes['genkit:metadata:subtype'] as string;
+    if (!logInputAndOutput || type === 'embedder' || type === 'indexer') {
+      return;
+    }
 
-    if (
-      type === 'promptTemplate' ||
-      subtype === 'tool' ||
-      actionName === 'generate'
-    ) {
-      const path = (attributes['genkit:path'] as string) || '<unknown>';
-      const input = truncate(attributes['genkit:input'] as string);
-      const output = truncate(attributes['genkit:output'] as string);
-      const sessionId = attributes['genkit:sessionId'] as string;
-      const threadName = attributes['genkit:threadName'] as string;
-      let featureName = extractOuterFeatureNameFromPath(path);
-      if (!featureName || featureName === '<unknown>') {
-        featureName = actionName;
-      }
+    const actionName = (attributes['genkit:name'] as string) || '<unknown>';
+    const path = (attributes['genkit:path'] as string) || '<unknown>';
+    const input = truncate(attributes['genkit:input'] as string);
+    const output = truncate(attributes['genkit:output'] as string);
+    const sessionId = attributes['genkit:sessionId'] as string;
+    const threadName = attributes['genkit:threadName'] as string;
+    let featureName = extractOuterFeatureNameFromPath(path);
+    if (!featureName || featureName === '<unknown>') {
+      featureName = actionName;
+    }
 
-      if (input) {
-        this.writeLog(
-          span,
-          'Input',
-          featureName,
-          path,
-          input,
-          projectId,
-          sessionId,
-          threadName
-        );
-      }
-      if (output) {
-        this.writeLog(
-          span,
-          'Output',
-          featureName,
-          path,
-          output,
-          projectId,
-          sessionId,
-          threadName
-        );
-      }
+    if (input) {
+      this.writeLog(
+        span,
+        'Input',
+        featureName,
+        path,
+        input,
+        projectId,
+        sessionId,
+        threadName
+      );
+    }
+    if (output) {
+      this.writeLog(
+        span,
+        'Output',
+        featureName,
+        path,
+        output,
+        projectId,
+        sessionId,
+        threadName
+      );
     }
   }
 

js/plugins/google-cloud/tests/logs_test.ts

@@ -395,7 +395,6 @@ describe('GoogleCloudLogs', () => {
     await getExportedSpans();
 
     const logs = await getLogs(1, 100, logLines);
-    expect(logs.length).toEqual(9);
     const logObjectMessages = getStructuredLogMessages(logs);
     expect(logObjectMessages).toContain(
       'Config[testFlow > sub1 > sub2 > generate > testModel, testModel]'