[VS Code] Add more metrics (#9299)

* Add some metrics in VS Code

* revert

* m

* bug

* more metrics

* m

Author: fredzqm

firebase-vscode/src/analytics.ts

@@ -21,12 +21,20 @@ export enum DATA_CONNECT_EVENT_NAME {
   PROJECT_SELECTED = "project_selected",
   RUN_LOCAL = "run_local",
   RUN_PROD = "run_prod",
+  RUN_PROD_MUTATION_WARNING = "run_prod_mutation_warning",
+  RUN_PROD_MUTATION_WARNING_REJECTED = "run_prod_mutation_warning_rejected",
+  RUN_PROD_MUTATION_WARNING_ACKED = "run_prod_mutation_warning_acked",
+  RUN_PROD_MUTATION_WARNING_ACKED_ALWAYS = "run_prod_mutation_warning_acked_always",
+  MISSING_VARIABLES = "missing_variables",
   GENERATE_OPERATION = "generate_operation",
+  GIF_TOS_MODAL = "gif_tos_modal",
+  GIF_TOS_MODAL_ACKED = "gif_tos_modal_acked",
+  GIF_TOS_MODAL_CLICKED = "gif_tos_modal_clicked",
+  GIF_TOS_MODAL_REJECTED = "gif_tos_modal_rejected",
   ADD_DATA = "add_data",
   READ_DATA = "read_data",
   MOVE_TO_CONNECTOR = "move_to_connector",
   START_EMULATOR_FROM_EXECUTION = "start_emulator_from_execution",
-  REFUSE_START_EMULATOR_FROM_EXECUTION = "refuse_start_emulator_from_execution",
   INIT = "init",
   INIT_SDK = "init_sdk",
   INIT_SDK_CLI = "init_sdk_cli",
@@ -36,11 +44,6 @@ export enum DATA_CONNECT_EVENT_NAME {
   SESSION_CHAR_COUNT = "session_char_count",
   EMULATOR_EXPORT = "emulator_export",
   SETUP_FIREBASE_BINARY = "setup_firebase_binary",
-  GEMINI_ERROR = "gemini_error",
-  GEMINI_OPERATION_CALL = "gemini_operation_call",
-  GEMINI_SCHEMA_CALL = "gemini_schema_call",
-  GEMINI_SUCCESS = "gemini_success",
-  TRY_GEMINI_CLICKED = "try_gemini_clicked",
   TRY_FIREBASE_AGENT_CLICKED = "try_firebase_agent_in_gemini_clicked",
   MCP_DOCS_CLICKED = "mcp_docs_clicked",
   GIF_TOS_CLICKED = "gif_tos_clicked",

firebase-vscode/src/data-connect/ai-tools/firebase-mcp.ts

@@ -1,11 +1,9 @@
-import {
-  gemini,
-  gemini as geminiToolModule,
-} from "../../../../src/init/features/aitools/gemini";
+import { gemini as geminiToolModule } from "../../../../src/init/features/aitools/gemini";
 import * as vscode from "vscode";
 import { firebaseConfig } from "../config";
 import { ExtensionBrokerImpl } from "../../extension-broker";
 import { AnalyticsLogger, DATA_CONNECT_EVENT_NAME } from "../../analytics";
+import { configstore } from "../../../../src/configstore";
 
 const GEMINI_EXTENSION_ID = "google.geminicodeassist";
 
@@ -49,6 +47,7 @@ async function ensureGeminiExtension(): Promise<boolean> {
 
 // Writes MCP config, then opens up Gemini with a new chat
 async function openGeminiChat() {
+  configstore.set("gemini", true);
   writeToGeminiConfig();
   await vscode.commands.executeCommand("cloudcode.gemini.chatView.focus");
   await vscode.commands.executeCommand("geminicodeassist.agent.chat.new");

firebase-vscode/src/data-connect/execution/execution.ts

@@ -130,6 +130,18 @@ export function registerExecution(
     { document, documentPath, position }: OperationLocation,
     instance: InstanceType,
   ) {
+    analyticsLogger.logger.logUsage(
+      instance === InstanceType.LOCAL
+        ? DATA_CONNECT_EVENT_NAME.RUN_LOCAL
+        : DATA_CONNECT_EVENT_NAME.RUN_PROD,
+    );
+    analyticsLogger.logger.logUsage(
+      instance === InstanceType.LOCAL
+        ? DATA_CONNECT_EVENT_NAME.RUN_LOCAL + `_${ast.operation}`
+        : DATA_CONNECT_EVENT_NAME.RUN_PROD + `_${ast.operation}`,
+    );
+    await vscode.window.activeTextEditor?.document.save();
+
     // hold last execution in memory, and send operation name to webview
     lastExecutionInputSignal.value = {
       ast,
@@ -170,6 +182,7 @@ export function registerExecution(
       !configs.get(alwaysExecuteMutationsInProduction) &&
       ast.operation === OperationTypeNode.MUTATION
     ) {
+      analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.RUN_PROD_MUTATION_WARNING);
       const always = "Yes (always)";
       const yes = "Yes";
       const result = await vscode.window.showWarningMessage(
@@ -179,17 +192,28 @@ export function registerExecution(
         always,
       );
 
-      if (result !== always && result !== yes) {
-        return;
-      }
-
-      // If the user selects "always", we update User settings.
-      if (result === always) {
-        configs.update(
-          alwaysExecuteMutationsInProduction,
-          true,
-          ConfigurationTarget.Global,
-        );
+      switch (result) {
+        case yes:
+          analyticsLogger.logger.logUsage(
+            DATA_CONNECT_EVENT_NAME.RUN_PROD_MUTATION_WARNING_ACKED
+          );
+          break;
+        case always:
+          // If the user selects "always", we update User settings.
+          configs.update(
+            alwaysExecuteMutationsInProduction,
+            true,
+            ConfigurationTarget.Global,
+          );
+          analyticsLogger.logger.logUsage(
+            DATA_CONNECT_EVENT_NAME.RUN_PROD_MUTATION_WARNING_ACKED_ALWAYS
+          );
+          break;
+        default:
+          analyticsLogger.logger.logUsage(
+            DATA_CONNECT_EVENT_NAME.RUN_PROD_MUTATION_WARNING_REJECTED
+          );
+          return;
       }
     }
 
@@ -237,6 +261,7 @@ export function registerExecution(
 
     // prompt user to continue execution or modify arguments
     if (missingArgs.length > 0) {
+      analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.MISSING_VARIABLES);
       // open a modal with option to run anyway or edit args
       const editArgs = { title: "Edit variables" };
       const continueExecution = { title: "Continue Execution" };
@@ -314,6 +339,7 @@ export function registerExecution(
   }
 
   async function generateOperation(arg: GenerateOperationInput) {
+    analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.GENERATE_OPERATION);
     if (!arg.projectId) {
       vscode.window.showErrorMessage(`Connect a Firebase project to use Gemini in Firebase features.`);
       return;
@@ -339,6 +365,7 @@ ${schema}
   }
 
   async function showGiFToSModal(projectId: string): Promise<boolean> {
+    analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.GIF_TOS_MODAL);
     const tos = "Terms of Service";
     const enable = "Enable";
     const result = await vscode.window.showWarningMessage(
@@ -352,15 +379,20 @@ ${schema}
     );
     switch (result) {
       case enable:
+        analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.GIF_TOS_MODAL_ACKED);
         configstore.set("gemini", true);
         await ensureGIFApiTos(projectId);
         return true;
       case tos:
+        analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.GIF_TOS_MODAL_CLICKED);
         vscode.env.openExternal(
           vscode.Uri.parse(
             "https://firebase.google.com/docs/gemini-in-firebase#how-gemini-in-firebase-uses-your-data",
           ),
         );
+      default:
+        analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.GIF_TOS_MODAL_REJECTED);
+        break;
     }
     return false;
   }
@@ -390,21 +422,12 @@ ${schema}
     vscode.commands.registerCommand(
       "firebase.dataConnect.executeOperation",
       async (ast, location, instanceType: InstanceType) => {
-        analyticsLogger.logger.logUsage(
-          instanceType === InstanceType.LOCAL
-            ? DATA_CONNECT_EVENT_NAME.RUN_LOCAL
-            : DATA_CONNECT_EVENT_NAME.RUN_PROD,
-        );
-        await vscode.window.activeTextEditor?.document.save();
         await executeOperation(ast, location, instanceType);
       },
     ),
     vscode.commands.registerCommand(
       "firebase.dataConnect.generateOperation",
       async (arg: GenerateOperationInput) => {
-        analyticsLogger.logger.logUsage(
-            DATA_CONNECT_EVENT_NAME.GENERATE_OPERATION,
-        );
         await generateOperation(arg);
       },
     ),
@@ -493,14 +516,3 @@ function getDefaultArgs(args: TypedInput[]) {
     return acc;
   }, {});
 }
-
-// converts AST OperationDefinitionNode to a DocumentNode for schema validation
-function operationDefinitionToDocument(
-  operationDefinition: OperationDefinitionNode,
-): DocumentNode {
-  return {
-    kind: Kind.DOCUMENT,
-    definitions: [operationDefinition],
-    loc: operationDefinition.loc,
-  };
-}

firebase-vscode/src/data-connect/index.ts

@@ -155,6 +155,7 @@ export function registerFdc(
     dataConnectToolkit,
     emulatorController,
     context,
+    analyticsLogger,
   );
 
   // register codelens

firebase-vscode/src/data-connect/service.ts

@@ -30,6 +30,7 @@ import { Client, ClientResponse } from "../../../src/apiv2";
 import { InstanceType } from "./code-lens-provider";
 import { pluginLogger } from "../logger-wrapper";
 import { DataConnectToolkit } from "./toolkit";
+import { AnalyticsLogger, DATA_CONNECT_EVENT_NAME } from "../analytics";
 
 /**
  * DataConnect Emulator service
@@ -40,6 +41,7 @@ export class DataConnectService {
     private dataConnectToolkit: DataConnectToolkit,
     private emulatorsController: EmulatorsController,
     private context: ExtensionContext,
+    private analyticsLogger: AnalyticsLogger,
   ) {}
 
   async servicePath(path: string): Promise<string> {
@@ -56,6 +58,7 @@ export class DataConnectService {
   private async handleProdResponse(
     response: ClientResponse<GraphqlResponse | GraphqlResponseError>,
   ): Promise<ExecutionResult> {
+    this.analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.RUN_PROD + `_${response.status}`);
     if (!(response.status >= 200 && response.status < 300)) {
       const errorResponse = response as ClientResponse<GraphqlResponseError>;
       throw new DataConnectError(
@@ -69,6 +72,7 @@ export class DataConnectService {
   private async handleEmulatorResponse(
     response: ClientResponse<GraphqlResponse | GraphqlResponseError>,
   ): Promise<ExecutionResult> {
+    this.analyticsLogger.logger.logUsage(DATA_CONNECT_EVENT_NAME.RUN_LOCAL + `_${response.status}`);
     if (!(response.status >= 200 && response.status < 300)) {
       const errorResponse = response as ClientResponse<GraphqlResponseError>;
       throw new DataConnectError(

firebase-vscode/src/data-connect/terminal.ts

@@ -102,7 +102,6 @@ export function registerTerminalTasks(
     if (settings.exportOnExit) {
       cmd += ` --export-on-exit ${settings.exportPath}`;
     }
-    vscode.window.showInformationMessage("Starting emulators... Please see terminal.");
     runTerminalTask(
       "firebase emulators",
       cmd,