Skip to content

Commit d7ff369

Browse files
authored
Add App Check support for Firestore (#1228)
* Add App Check logic to Firestore * Add more tests, and formatting * Update integration_test.cc * Update app_check_desktop.h * Update integration_test.cc * Update app_check_desktop.cc * Update integration_test.cc * Update integration_test.cc * Update integration_test.cc * Update based on feedback * File formatting
1 parent cb719bd commit d7ff369

16 files changed

+748
-20
lines changed

app/src/function_registry.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ enum FunctionId {
3636
FnAuthAddAuthStateListener,
3737
FnAuthRemoveAuthStateListener,
3838
FnAppCheckGetTokenAsync,
39+
FnAppCheckAddListener,
40+
FnAppCheckRemoveListener,
3941
};
4042

4143
// Class for providing a generic way for firebase libraries to expose their

app_check/integration_test/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ endif()
234234
# Add the Firebase libraries to the target using the function from the SDK.
235235
add_subdirectory(${FIREBASE_CPP_SDK_DIR} bin/ EXCLUDE_FROM_ALL)
236236
# Note that firebase_app needs to be last in the list.
237-
set(firebase_libs firebase_app_check firebase_database firebase_storage firebase_functions firebase_auth firebase_app)
237+
set(firebase_libs firebase_app_check firebase_database firebase_storage firebase_functions firebase_firestore firebase_auth firebase_app)
238238
set(gtest_libs gtest gmock)
239239
target_link_libraries(${integration_test_target_name} ${firebase_libs}
240240
${gtest_libs} ${ADDITIONAL_LIBS})

app_check/integration_test/Podfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ target 'integration_test' do
99
pod 'Firebase/Auth', '10.6.0'
1010
pod 'Firebase/Storage', '10.6.0'
1111
pod 'Firebase/Functions', '10.6.0'
12+
pod 'Firebase/Firestore', '10.6.0'
1213
end
1314

1415
target 'integration_test_tvos' do
@@ -18,6 +19,7 @@ target 'integration_test_tvos' do
1819
pod 'Firebase/Auth', '10.6.0'
1920
pod 'Firebase/Storage', '10.6.0'
2021
pod 'Firebase/Functions', '10.6.0'
22+
pod 'Firebase/Firestore', '10.6.0'
2123
end
2224

2325
post_install do |installer|

app_check/integration_test/build.gradle

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ android {
6565
"-DFIREBASE_INCLUDE_AUTH=ON",
6666
"-DFIREBASE_INCLUDE_DATABASE=ON",
6767
"-DFIREBASE_INCLUDE_STORAGE=ON",
68-
"-DFIREBASE_INCLUDE_FUNCTIONS=ON"
68+
"-DFIREBASE_INCLUDE_FUNCTIONS=ON",
69+
"-DFIREBASE_INCLUDE_FIRESTORE=ON"
6970
}
7071
}
7172
externalNativeBuild.cmake {
@@ -87,6 +88,7 @@ firebaseCpp.dependencies {
8788
database
8889
storage
8990
functions
91+
firestore
9092
}
9193

9294
apply plugin: 'com.google.gms.google-services'

0 commit comments

Comments
 (0)