Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetaFieldGenerator is generating too much Java files #844

Closed
SimonCockx opened this issue Sep 19, 2024 · 0 comments · Fixed by #851
Closed

MetaFieldGenerator is generating too much Java files #844

SimonCockx opened this issue Sep 19, 2024 · 0 comments · Fixed by #851

Comments

@SimonCockx
Copy link
Contributor

In a recent PR, a condition has accidentally slightly changed, which is causing superfluous Java files to be generated. This causes longer compilation times.

See c20eb67#diff-8009a8dbaf539bf5ba5c94ea3b47e647586227addce959d73e56fd8637e33f0eL110
condition hasMetas (also on line 92).
SimonCockx added a commit to REGnosys/rune-dsl that referenced this issue Oct 2, 2024
@SimonCockx
Fixed finos#844
4f256bf
@SimonCockx SimonCockx linked a pull request Oct 2, 2024 that will close this issue
Fix #844 #851
Merged
SimonCockx added a commit that referenced this issue Oct 2, 2024
@SimonCockx
Fixed #844 (#851)
842f63f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #844 REGnosys/rune-dsl
1 participant
@SimonCockx