Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TB] Change default design system, atom defaults to match wireframes #968

Closed
Tracked by #820
aaronreed708 opened this issue Jul 22, 2024 · 1 comment
Closed
Tracked by #820
Assignees
Labels
sdk Software development kit theme builder app Theme Builder application

Comments

@aaronreed708
Copy link
Contributor

Problem/Concern

Part of the work for #820 that @omesh-omg is working on, we need to determine if we need to change the default Theme Builder theme values to match the wireframes. For example, Should our primary buttons be orange, should selected menu items be orange? Should the main navbar background and save bar background be a dark blue?

@lwnoble assigning to you in order to get the decision if we need to change the default theme values and, if so, what the new values should be.

Proposed Solution

We need to update the default Theme Builder theme to carry the correct default values and make sure that those defaults are honored/used by the SDK where appropriate. We should not accomplish these changes using new CSS rules.

@aaronreed708
Copy link
Contributor Author

aaronreed708 commented Jul 25, 2024

Per @lwnoble in yesterday's call, wireframe color changes NOT intentional. Current default palette should be used. The only changes to the default themes will likely be to establish defaults for any new components or new atomic elements.

@aaronreed708 aaronreed708 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk Software development kit theme builder app Theme Builder application
Projects
Status: Done
Development

No branches or pull requests

2 participants