-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client-side example mistakenly refer to wrong name "symbol" in PrivateChannel doc #1279
Comments
I can open PR to fix this if necessary, thanks. |
You are correct, there is an error here: FDC3/docs/api/ref/PrivateChannel.md Line 80 in aaa2a80
When raising a PR to fix this, it should also be fixed in past versions:
And a Changelog entry in the FIxed section would also be appreciated: https://github.com/finos/FDC3/blob/main/CHANGELOG.md |
I verified the pending .NET sample in #1108 has Ticker as the ID property |
will raise PR, thanks @kriswest |
PR opened, #1314, thanks |
closed as completed |
Minor Issue
Client-side example mistakenly refer to wrong name "symbol" in PrivateChannel doc, it should be 'ticker' like below.
for below reasons:
Area of Issue
[ ] App Directory
[*] API
[ ] Context Data
[ ] Intents
[ ] Desktop Agent Bridging
[ ] Use Cases
[ ] Other
The text was updated successfully, but these errors were encountered: