Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in https://fdc3.finos.org/docs/next/api/spec #1273

Closed
Juno-888 opened this issue Jul 19, 2024 · 2 comments
Closed

Broken link in https://fdc3.finos.org/docs/next/api/spec #1273

Juno-888 opened this issue Jul 19, 2024 · 2 comments
Labels
docs Documentation good first issue Good for newcomers needs-pr

Comments

@Juno-888
Copy link
Contributor

The Context link in Implementation language session is invalid in https://fdc3.finos.org/docs/next/api/spec
After clicking the Context link in the image, it jumps to a incorrect URL(https://fdc3.finos.org/docs/next/api/ref/Context) with 404 page.
I think the correct URL reference should be https://fdc3.finos.org/docs/next/context/ref/Context.

You can refer to the snapshot below to find the issue:
image

I open a PR to edit. Free to get in touch with me.

@Juno-888 Juno-888 added the bug Something isn't working label Jul 19, 2024
@kriswest kriswest added good first issue Good for newcomers docs Documentation and removed bug Something isn't working labels Jul 22, 2024
@kriswest
Copy link
Contributor

@Juno-888 you are correct that the link is wrong.

However, we're going to get rid of the Context reference page shortly (in this PR - heres a preview) and integrate it into the context overview (as fdc3.context is the base for other context types, rather than being a context type of its own). Hence, if you are going to raise a PR to fix this, can you link to the context overview instead please - I'd suggest this is the right link: https://fdc3.finos.org/docs/next/context/spec#the-context-interface which you would specify as context/spec#the-context-interface I think.

@kriswest
Copy link
Contributor

closed as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation good first issue Good for newcomers needs-pr
Projects
None yet
Development

No branches or pull requests

2 participants