1255 Make fdc3.fileAttachment and independent type #1261
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -38,38 +38,7 @@ | |||
| "$ref": "action.schema.json#" | |||
There was a problem hiding this comment.
@Yannick-Malins can you change the additionalProperties.anyOf to oneOf - the semantics are virtually the same, but the code generation via QuickType differs (it'll merge properties with anyOf as you could be multiple of the referenced types at once, where we intend it to be oneOf the referenced types)
There was a problem hiding this comment.
@Yannick-Malins The change I'm after is on line 36 above. Otherwise, this is good to merge, apart from a Changelog entry and the $id I flagged above.
There was a problem hiding this comment.
LGTM - although I think Message's entities element needs to be defined with oneOf rather than anyOf. Could you change that, add a Changelog entry and then I'll approve and merge the change (new governance restrictions will invalidate any reviews that happen before a later change)
kriswest
changed the title
| @@ -0,0 +1,53 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-07/schema#", | |||
| "$id": "https://fdc3.finos.org/schemas/next/context/attachment.schema.json", | |||
There was a problem hiding this comment.
the filename and this $id need to match, please change to: https://fdc3.finos.org/schemas/next/context/fileAttachment.schema.json
#1255