Add tooltip to KeyValueGridView #1399
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstien
reviewed
Feb 12, 2025
FinniversKit/Sources/Components/KeyValueGridView/KeyValueGridView.swift
Outdated
Show resolved
Hide resolved
bstien
reviewed
Feb 12, 2025
FinniversKit/Sources/Components/KeyValueGridView/KeyValueGridView.swift
Outdated
Show resolved
Hide resolved
|
How does this look in the app if you show it on the itempage, and then scroll the screen? Does the tooltip scroll alongside, or is it "stuck" in its initial position? |
bstien
reviewed
Feb 12, 2025
FinniversKit/Sources/Extensions/UIKit/UIApplicationExtensions.swift
Outdated
Show resolved
Hide resolved
bstien
reviewed
Feb 12, 2025
Comment on lines
+104
to
+106
| let infoButton = UIButton(type: .custom) | ||
| infoButton.setImage(Warp.Icon.info.uiImage, for: .normal) | ||
| infoButton.translatesAutoresizingMaskIntoConstraints = false |
There was a problem hiding this comment.
There's no label for VoiceOver users for this button. How should the button and the presentation work for them?
It looks like this. And I am not able to scroll until I close the tooltip (by clicking on any part of the screen ScreenRecording_02-12-2025.13-33-02_1.MP4 |
| infoButton.setImage(Warp.Icon.info.uiImage, for: .normal) | ||
| infoButton.translatesAutoresizingMaskIntoConstraints = false | ||
| infoButton.accessibilityLabel = pair.infoTooltipAccessibilityLabel | ||
| NSLayoutConstraint.activate([ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
A tooltip was requested on the Mobility Item Page to provide brief explanatory text for a specific specification.
What?
infoTooltipproperty inKeyValuePair.Tooltip implementation in
KeyValueGridView:infoTooltipis present.infoTooltipcontent on click.Version Change
Minor
UI Changes