Add region capabilities for s3 destination #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schorzz
force-pushed
the
feature/configurable-s3-region
branch
from
99bf51d
to
e52489e
Compare
ckoehn
reviewed
Mar 3, 2022
pkg/util/env.go
Outdated
| @@ -24,3 +24,11 @@ func FallbackToEnv(value string, envName string) string { | |||
| } | |||
| return value | |||
| } | |||
|
|
|||
| func FallbackToDefault(fallback string, envName string) string { | |||
There was a problem hiding this comment.
Suggested change
| func FallbackToDefault(fallback string, envName string) string { | |
| func EnvWithDefault(name string, d string) string { |
What do you think of changing the order of arguments? It makes more sense in my head 😉
There was a problem hiding this comment.
Yeah, agree. I just wanted to have some kind of consistency between both util funcs. Makes also more sense to have the fallback as 2nd argument.
schorzz
force-pushed
the
feature/configurable-s3-region
branch
from
e52489e
to
c196844
Compare
ckoehn
reviewed
Mar 4, 2022
| @@ -90,6 +90,7 @@ var consulCmd = &cobra.Command{ | |||
| DisableSSL: !s3c.UseSSL, | |||
| Bucket: s3c.Bucket, | |||
| Prefix: prefix, | |||
| Region: util.EnvWithDefault("us-east-1", "S3_REGION"), | |||
There was a problem hiding this comment.
The order of arguments is not correct since you changed the signature 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.