Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better referential equality in useField #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better referential equality in useField #65

wants to merge 1 commit into from

Conversation

Jephuff
Copy link
Contributor

@Jephuff Jephuff commented Feb 5, 2020

resolves #30
wraps onBlur, onChange, and onFocus in useCallback.
wraps input in useMemo

@codecov
Copy link

codecov bot commented Feb 5, 2020 •
edited
Loading

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #65   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          83     86    +3     
  Branches       17     17           
=====================================
+ Hits           83     86    +3
Impacted Files Coverage Δ
src/useField.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f273d6b...f4e96ef. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance via referential equality on useForm functions
1 participant
@Jephuff