Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve return type-hints #44

Open
chbakouras opened this issue Nov 19, 2019 · 1 comment
Open

Improve return type-hints #44

chbakouras opened this issue Nov 19, 2019 · 1 comment

Comments

@chbakouras
Copy link

Currently, the library uses type-hints that not exist.

For example, FilestackClient has a convertFile method that has a return type-hint of Filestack/Filelink while the correct one is \Filestack\Filelink.

This improvement will allow us to use the type-hint properly into php7+ projects.
@chbakouras
Copy link
Author

Any update on this? Should I create a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chbakouras