Update

Author: 0x5bfa

src/Files.App/Actions/FileSystem/RestoreAllRecycleBinAction.cs

@@ -41,22 +41,10 @@ public async Task ExecuteAsync(object? parameter = null)
 			if (await confirmationDialog.TryShowAsync() is not ContentDialogResult.Primary)
 				return;
 
-			//using var sop = new ShellFileOperations { Options = GetDeleteOpFlags(hideUI) };
-			//HRESULT hr = HRESULT.S_OK;
+			bool result = await WindowsRecycleBinService.RestoreAllAsync();
 
-			try
-			{
-				//foreach (var item in deletedItems)
-				//{
-				//	if (item.Parent != ShellFolderInstance) throw new InvalidOperationException("Unable to restore a ShellItem that is not in the Recycle Bin.");
-				//	// Manually create a ShellFolder instance to the original location.
-				//	using var sf = new ShellFolder(Path.GetDirectoryName(item.Name)!);
-				//	sop.QueueMoveOperation(item, sf, Path.GetFileName(item.Name));
-				//}
-				//sop.PerformOperations();
-				//hr.ThrowIfFailed();
-			}
-			catch (Exception)
+			// Show error dialog when failed
+			if (!result)
 			{
 				var errorDialog = new ContentDialog()
 				{
@@ -69,17 +57,6 @@ public async Task ExecuteAsync(object? parameter = null)
 
 				await errorDialog.TryShowAsync();
 			}
-			finally
-			{
-				try
-				{
-					// Call the undocumented function to reset the icon.
-					//SHUpdateRecycleBinIcon();
-				}
-				catch
-				{
-				}
-			}
 		}
 	}
 }

src/Files.App/Data/Contracts/IWindowsRecycleBinService.cs

@@ -17,6 +17,6 @@ public interface IWindowsRecycleBinService : ITrashWatcher
 
 		Task<bool> DeleteAllAsync();
 
-		bool RestoreAll();
+		Task<bool> RestoreAllAsync();
 	}
 }

src/Files.App/Services/Windows/WindowsRecycleBinService.cs

@@ -3,6 +3,7 @@
 
 using System.Security.Principal;
 using Windows.Win32;
+using Windows.Win32.Foundation;
 
 namespace Files.App.Services
 {
@@ -81,16 +82,52 @@ public async Task<bool> DeleteAllAsync()
 				PInvoke.SHEmptyRecycleBin(
 					new(),
 					string.Empty,
-					0x00000001 | 0x00000002 /*SHERB_NOCONFIRMATION | SHERB_NOPROGRESSUI*/)
+					0x00000001 | 0x00000002 /* SHERB_NOCONFIRMATION | SHERB_NOPROGRESSUI */)
 				.Succeeded);
 
 			return fRes;
 		}
 
 		/// <inheritdoc/>
-		public bool RestoreAll()
+		public async Task<bool> RestoreAllAsync()
 		{
-			return true;
+			try
+			{
+				bool fRes = await Task.Run(() =>
+				{
+					HRESULT hr = (HRESULT)0; /* S_OK */
+
+					//using var sop = new ShellFileOperations { Options = GetDeleteOpFlags(hideUI) };
+					//foreach (var item in deletedItems)
+					//{
+					//	if (item.Parent != ShellFolderInstance) throw new InvalidOperationException("Unable to restore a ShellItem that is not in the Recycle Bin.");
+					//	// Manually create a ShellFolder instance to the original location.
+					//	using var sf = new ShellFolder(Path.GetDirectoryName(item.Name)!);
+					//	sop.QueueMoveOperation(item, sf, Path.GetFileName(item.Name));
+					//}
+					//sop.PerformOperations();
+					//hr.ThrowIfFailed();
+
+					return true;
+				});
+
+				return fRes;
+			}
+			catch
+			{
+				return false;
+			}
+			finally
+			{
+				try
+				{
+					// Reset the icon.
+					//Win32PInvoke.SHUpdateRecycleBinIcon();
+				}
+				catch
+				{
+				}
+			}
 		}
 
 		/// <inheritdoc/>