FIXED

Author: 0x5bfa

src/Files.App/NativeMethods.txt

@@ -87,4 +87,5 @@ GetComputerName
 AddAccessAllowedAceEx
 LocalAlloc
 InitializeAcl
-AddAce
+AddAce
+LocalFree

src/Files.App/Services/Storage/StorageSecurityService.cs

@@ -169,7 +169,7 @@ public unsafe WIN32_ERROR GetAcl(string path, bool isFolder, out AccessControlLi
 		public unsafe WIN32_ERROR AddAce(string szPath, bool isFolder, string szSid)
 		{
 			ACL* pDACL = default;
-			//ACL* pNewDACL = default;
+			ACL* pNewDACL = default;
 			PSID pSid = default;
 			ACL_SIZE_INFORMATION aclSizeInfo = default;
 			ACCESS_ALLOWED_ACE* pTempAce = default;
@@ -190,28 +190,28 @@ public unsafe WIN32_ERROR AddAce(string szPath, bool isFolder, string szSid)
 
 			// Get ACL size info
 			bool bResult = PInvoke.GetAclInformation(
-				*pDACL,
+				pDACL,
 				&aclSizeInfo,
 				(uint)Marshal.SizeOf<ACL_SIZE_INFORMATION>(),
 				ACL_INFORMATION_CLASS.AclSizeInformation);
 
 			if (!bResult)
 				return (WIN32_ERROR)Marshal.GetLastPInvokeError();
 
-			var cbNewDACL = aclSizeInfo.AclBytesInUse + aclSizeInfo.AclBytesFree + Marshal.SizeOf<ACCESS_ALLOWED_ACE>();
-			uint dwAclCount = aclSizeInfo.AceCount;
+			var cbNewDACL = aclSizeInfo.AclBytesInUse + aclSizeInfo.AclBytesFree + Marshal.SizeOf<ACCESS_ALLOWED_ACE>() * 2;
 
-			//// Allocate space for the new DACL that contains the new ACE
-			//PInvoke.LocalAlloc(LOCAL_ALLOC_FLAGS.LPTR, (nuint)cbNewDACL);
+			pNewDACL = (ACL*)PInvoke.LocalAlloc(LOCAL_ALLOC_FLAGS.LPTR, (nuint)cbNewDACL);
+			if (pNewDACL == default)
+				return (WIN32_ERROR)Marshal.GetLastPInvokeError();
 
 			// Initialize the new DACL
-			PInvoke.InitializeAcl(out ACL pNewDACL, (uint)cbNewDACL, ACE_REVISION.ACL_REVISION);
+			PInvoke.InitializeAcl(pNewDACL, (uint)cbNewDACL, ACE_REVISION.ACL_REVISION);
 
 			// Copy ACEs from the old DACL
-			for (uint dwAceIndex = 0u; dwAceIndex < dwAclCount; dwAceIndex++)
+			for (uint dwAceIndex = 0u; dwAceIndex < aclSizeInfo.AceCount; dwAceIndex++)
 			{
 				bResult = PInvoke.GetAce(pDACL, dwAceIndex, (void**)&pTempAce);
-				PInvoke.AddAce(&pNewDACL, ACE_REVISION.ACL_REVISION, uint.MaxValue, (void*)pTempAce, pTempAce->Header.AceSize);
+				PInvoke.AddAce(pNewDACL, ACE_REVISION.ACL_REVISION, uint.MaxValue, pTempAce, pTempAce->Header.AceSize);
 			}
 
 			// Get the principal's SID of the new ACE
@@ -237,7 +237,7 @@ public unsafe WIN32_ERROR AddAce(string szPath, bool isFolder, string szSid)
 					OBJECT_SECURITY_INFORMATION.DACL_SECURITY_INFORMATION | OBJECT_SECURITY_INFORMATION.PROTECTED_DACL_SECURITY_INFORMATION,
 					new PSID((void*)0),
 					new PSID((void*)0),
-					&pNewDACL);
+					pNewDACL);
 			}
 
 			if (result is not WIN32_ERROR.ERROR_SUCCESS)