Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review dependencies and remove the ones without concrete tag #12503

Open
3 tasks
masih opened this issue Sep 23, 2024 · 3 comments
Open
3 tasks

Review dependencies and remove the ones without concrete tag #12503

masih opened this issue Sep 23, 2024 · 3 comments

Comments

@masih
Copy link
Member

masih commented Sep 23, 2024

There are quite a few "wild" dependencies in Lotus go module; ones that:

  • have no concrete tag.
  • have unclear cost/benefit.
  • Review the dependencies without concrete tag.
  • Remove them if possible in cases where the usage is minimal and better alternatives exist.
  • Cut a tag or upgrade anything else that's hard to get rid of.

This issue is done when there are no wild dependencies in Lotus go mod, or there is a comment above the ones we can't get rid of explaining why.

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 23, 2024
@BigLep
Copy link
Member

BigLep commented Sep 25, 2024

@masih : I agree this would be done. To ensure we don't backslide or make the problem worse, I think we need to do #7131

@rjan90
Copy link
Contributor

rjan90 commented Sep 30, 2024

Posting here since it came up in a review/comment: Check if we can get rid of the filecoin-ffi dependency in the require section in the go.mod file:

lotus/go.mod

Lines 40 to 41 in d017c15

github.com/filecoin-project/filecoin-ffi v1.28.0-rc2
github.com/filecoin-project/go-address v1.1.0

Since we already ask it to use the local directory

lotus/go.mod

Lines 13 to 14 in d017c15

replace github.com/filecoin-project/filecoin-ffi => ./extern/filecoin-ffi // provided via a git submodule

Edit

Got my answer here: #12524 (comment)

@rjan90
Copy link
Contributor

rjan90 commented Oct 22, 2024

Idea is to get all dependencies to be on a tag, and clean up the dependency tree. I will put this up on the Hacking Topic Item Proposals for Bangkok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📌 Triage
Development

No branches or pull requests

3 participants