-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI verifies that Lotus works with existing common smart contract developer tools #12362
Comments
Check this repo out where I think a lot of the concerns of "FEVM/Lotus issues" are fixed: https://github.com/consensus-shipyard/fevm-contract-tests and here's a recent run of the CI https://github.com/consensus-shipyard/ipc/actions/runs/10368566513/job/28702463734 |
Thanks @snissn. Are you suggesting we should be able to follow what consensus-shipyard/ipc does to have these tests run in Lotus' CI? Also, do you know why this was forked from filecoin-project vs. being updated there? |
That's pretty cool, does this CI touch Lotus at all as it is, or is this all fendermint and the rest of the IPC stack? |
For visibility, work is being done to update fevm-contract-tests in filecoin-project/fevm-contract-tests#26 |
2024-09-04 maintainer conversation notes: this is going to need to run on a periodic basis (and not against each PR) because the tests can take a long time to run. Implementation note: we can follow a similar pattern of #12234 to run this on cron and open/update an issue on failure. |
Done Criteria
We have a CI check that asserts that https://github.com/filecoin-project/fevm-contract-tests still pass against Lotus.
Why Important
Currently many Lotus maintainers aren't cognizant of EVM developer toolchains and may not be able to anticipate breakages. if a Lotus change breaks common EVM developer tools we at the minimum want to know about it and likely want to address the issue then.
User/Customer
Maintainers/contributors to make sure they don't cause regressions. This is being done in service of those doing smart contract development with FEVM.
Notes
The text was updated successfully, but these errors were encountered: