Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 2 approvals with "smart" branch protection #65

Open
Tracked by #47
BigLep opened this issue Aug 28, 2024 · 0 comments
Open
Tracked by #47

Require 2 approvals with "smart" branch protection #65

BigLep opened this issue Aug 28, 2024 · 0 comments
Assignees

Comments

@BigLep
Copy link
Member

BigLep commented Aug 28, 2024

This issue is considered done when we have the proper branch protection and GitHub Actions in place such that 2 CODEOWNER approvals are required or only 1 is required if the author is a CODEOWNER.

Per discussion in #61 (comment) , we want to ideally have 2 approvers to changes to this repo, but to make this not too burdensome, we ideally want it so only one approval is needed if the author is a CODEOWNER.

This is a followup task for #47

@BigLep BigLep changed the title Require 2 approval with "smart" branch protection Require 2 approvals with "smart" branch protection Aug 28, 2024
@BigLep BigLep self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant