Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise the datacap actor's allowance data into the same HAMT as balances #1101

Closed
Tracked by #1276 ...
anorth opened this issue Jan 24, 2023 · 3 comments
Closed
Tracked by #1276 ...
Labels
optimisation wontfix This will not be worked on

Comments

@anorth
Copy link
Member

anorth commented Jan 24, 2023

This is a tracking issue for filecoin-project/actors-utils#188.

Instrumentation suggests that changing the state schema for the datacap actor could lead to a significant reduction in gas used for the token transfers associated with verified deals.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Network nv19 Feb 24, 2023
@jennijuju jennijuju moved this from 📋 Backlog to 🔖 In Scope in Network nv19 Feb 24, 2023
@anorth anorth moved this from 🔖 In Scope to 📋 Backlog in Network nv19 Feb 26, 2023
@anorth
Copy link
Member Author

anorth commented Feb 26, 2023

This is a fairly large change that I don't think fits well with a fast-follow nv19. I'm removing from that project.

@alexytsu
Copy link
Contributor

Now that the datacap calls have themselves been batched as a part of #1278 there is only one call per PSD. The call to datacap accounts for around 1% of the gas of the entire routine so any internal optimisations here are unlikely to move the needle in the short term.

@anorth
Copy link
Member Author

anorth commented Jun 26, 2023

Thanks, I'm going to close this as wontfix. This is now only a small part of any built-in routines that use datacap. It could still be beneficial for new uses of the token library to combine this state, but not worth migrating datacap at the moment.

@anorth anorth closed this as completed Jun 26, 2023
@anorth anorth added the wontfix This will not be worked on label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimisation wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants