Skip to content
This repository was archived by the owner on May 6, 2025. It is now read-only.

Commit c60e210

Browse files
author
1138-4EB
committed
remove references to build_img* scripts (filebrowser/filebrowser#500)
1 parent 71e1f4c commit c60e210

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

ci_releases.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Currently, a single CI service is used: [travis-ci.com/filebrowser](https://trav
2424
- When the tag in [filebrowser/filebrowser](https://github.com/filebrowser/filebrowser) is pushed, [travis-ci](https://travis-ci.com/filebrowser/filebrowser/builds) detects it and two of the following stages (`0,1` or `0,2`) are automatically executed (see [`.travis.yml`](https://github.com/filebrowser/filebrowser/blob/master/.travis.yml)):
2525
- STAGE 0: golang linting tools ([gometalinter](https://github.com/alecthomas/gometalinter)) are executed. See [`build/run_gometalinter.sh`](https://github.com/filebrowser/filebrowser/blob/master/build/run_gometalinter.sh) and [`.gometalinter.json`](https://github.com/filebrowser/filebrowser/blob/master/.gometalinter.json).
2626
- STAGE 1: the frontend and the backend are built, thus `rice-box.go` is created. See [`build/build_all.sh`](https://github.com/filebrowser/filebrowser/blob/master/build/build_all.sh).
27-
- If the commit is not tagged, docker image `filebrowser/filebrowser` is built and it is pushed to [hub.docker.com/r/filebrowser/filebrowser](https://hub.docker.com/r/filebrowser/filebrowser/). See [`build/build_img.sh`](https://github.com/filebrowser/filebrowser/blob/master/build/build_img.sh).
27+
- If the commit is not tagged, docker image `filebrowser/filebrowser` is built and it is pushed to [hub.docker.com/r/filebrowser/filebrowser](https://hub.docker.com/r/filebrowser/filebrowser/).
2828
- STAGE 2: if the commit is tagged,
2929
- [goreleaser](https://github.com/goreleaser/goreleaser) is used to build the release artifacts for all the supported platforms and to build a single docker image (tagged/named twice). The artifacts are published to [GitHub Releases](https://github.com/filebrowser/filebrowser/releases) and the image is pushed to [hub.docker.com/r/filebrowser/filebrowser](https://hub.docker.com/r/filebrowser/filebrowser/). See [`.goreleaser.yml`](https://github.com/filebrowser/filebrowser/blob/master/.goreleaser.yml).
3030
- [`./build/push_ricebox.sh`](https://github.com/filebrowser/filebrowser/blob/master/build/push_ricebox.sh) is executed in order to update `rice-box.go` in [filebrowser/caddy/assets](https://github.com/filebrowser/caddy/tree/master/assets).

development.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,9 @@ In order to allow iterative and fast development, a bunch of scripts are provide
1212

1313
- [`build_assets.sh`](https://github.com/filebrowser/filebrowser/tree/master/build/build_assets.sh): get frontend dependencies, build the frontend and update `rice-box.go`.
1414
- [`build.sh`](https://github.com/filebrowser/filebrowser/tree/master/build/build.sh): build the backend.
15-
- [`build_img.sh`](https://github.com/filebrowser/filebrowser/tree/master/build/build_img.sh): build the `filebrowser/filebrowser` docker image.
1615
- [`build_all.sh`](https://github.com/filebrowser/filebrowser/tree/master/build/build_all.sh): execute `build_assets.sh` and `build.sh`, one after the other.
1716

18-
Furthermore, a docker image named [filebrowser/dev](https://hub.docker.com/r/filebrowser/dev/) is provided to support development/collaboration from hosts with a single dependency: [docker](https://www.docker.com/). This also allows to develop File Browser offline (see [No connection](#offline) below). You can either get it from [hub.docker.com/r/filebrowser/dev](https://hub.docker.com/r/filebrowser/dev/) or build it locally with [`build_img_dev.sh`](https://github.com/filebrowser/filebrowser/tree/master/build/build_img_dev.sh).
17+
Furthermore, a docker image named [filebrowser/dev](https://hub.docker.com/r/filebrowser/dev/) is provided to support development/collaboration from hosts with a single dependency: [docker](https://www.docker.com/). This also allows to develop File Browser offline (see [No connection](#offline) below). You can either get it from [hub.docker.com/r/filebrowser/dev](https://hub.docker.com/r/filebrowser/dev/) or build it locally (see [filebrowser/docker-dev](https://github.com/filebrowser/docker-dev)).
1918

2019
Note that the scripts above are the ones used in CI environments in order to have File Browser tested after each commit is pushed to the repo. Therefore, using these locally ensures consistency all along the design and deployment flow.
2120

@@ -40,11 +39,11 @@ If you are willing to install `nodejs`, `yarn`, `go`, `git`, `docker` and `shell
4039
If you want to install `docker` and `shell` only:
4140

4241
- `USE_DOCKER="true" ./build/build_all.sh` executes `build_assets.sh` and `build.sh` inside a `filebrowser/dev` container, instead of running them on the host.
43-
- `./build/build_img.sh` builds the `filebrowser/filebrowser` image.
42+
- `docker build -t filebrowser/filebrowser .` builds the docker image.
4443

4544
> NOTE: the repo can be cloned anywhere.
4645
47-
> NOTE: `build_img.sh` should be executed outside of the container.
46+
> NOTE: `docker build` should be executed outside of the container.
4847
4948
## Docker and shell, interactive
5049

0 commit comments

Comments
 (0)