-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook for when action modal is closed #10122
Comments
Hey, do you mind if I submit a PR for this? If I may, should I rename the after() hook to afterSubmit()? Then I can create afterClose/afterCancel() to avoid confusion. Or should I keep it just as afterClose()? |
Before implementing this I would like someone to reply here and let me know what use case they have for this hook, so that I can make sure needs are met. I have heard a lot of requests for this but would like to extra clarification before proceeding. |
I personally have no use for it, I made the PR because there was an issue for it. During the summer I accidentally deleted it though 😅. I can make it again if thats ok. If there is no use for the PR, we can ignore it. |
Yeah I'm just struggling to imagine how you would use it, hence why I haven't merged it |
Example usage:
|
Should you not do that when the modal is opened, |
I have a use case for this... I have a module that automatically opens unread announcements for users... one by one, so after the user closes, it automatically opens the next one... But i can think of many use cases for this, like setting the modal as read, maybe you want to track when the user opens it, but also when you closed... etc... |
Donate 💰 to fund this issue
The text was updated successfully, but these errors were encountered: