Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background in darkmode not full height for chrome #14687

Open
Lockyc opened this issue Nov 2, 2024 · 1 comment
Open

Background in darkmode not full height for chrome #14687

Lockyc opened this issue Nov 2, 2024 · 1 comment
Labels

Comments

@Lockyc
Copy link

Lockyc commented Nov 2, 2024

Package

filament/filament

Package Version

v3.2.115 & https://demo.filamentphp.com

Laravel Version

v11.25.0 & https://demo.filamentphp.com

Livewire Version

https://demo.filamentphp.com

PHP Version

v8.3 & https://demo.filamentphp.com

Problem description

I nearly submitted this issue with screenshots only.
Just before I did, I realised the issue I am seeing is only visible on my monitors.
When I view the page on my macbook screen and the issue is not there.
The same also applies for the screenshots, the background color difference is apparent in the screenshots when viewing on my monitor but not when i view the screenshots on my macbook screen.

I have included the screenshots, as well as some photos i took of my monitors with the issue.

The dark mode background does not display full height.
This occurs in the app i am building, the demo repository and https://demo.filamentphp.com
It appears to work in Firefox appropriately.

CleanShot 2024-11-02 at 19 03 58
CleanShot 2024-11-02 at 18 59 06
CleanShot 2024-11-02 at 18 58 59
CleanShot 2024-11-02 at 18 58 38
CleanShot 2024-11-02 at 18 58 36
IMG_2770
IMG_2769
IMG_2768

Expected behavior

The background to be displayed full height

Steps to reproduce

View the app in darkmode in chrome or chromium.

Reproduction repository (issue will be closed if this is not valid)

https://github.com/filamentphp/demo

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@Lockyc
Copy link
Author

Lockyc commented Nov 4, 2024

I used MacOS' Digital Colour Meter, its a minor difference but enough to show up in the right situation.

CleanShot 2024-11-05 at 07 23 36
CleanShot 2024-11-05 at 07 23 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant