-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filament/support subtree split incorrectly requires doctrine/dbal #11891
Comments
Hey @jackwh! We're sorry to hear that you've hit this issue. 💛 However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue? We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly. Also, it doesn't look like you've provided much information on how to replicate the issue. Please edit your original post with clear steps we need to take. |
Thank you for providing reproduction steps! Reopening the issue now. |
Filament used to use DBAL for resource generation. That PR replaced DBAL with Laravel's own implementation of database analysis. The dependency was removed. We then received reports of users using DBAL in their apps (#11429 (comment)). This is user error. They should be installing DBAL themselves instead of relying on the fact that Filament required it. However, due to the fact that this was kind of a breaking change, we decided to re-require DBAL to prevent those apps from breaking. This was a gesture of good will from Filament that we didn't need to do since it was user error, but thought it would make the situation more stable. So we will require DBAL until Filament v4 for users still depending on that incorrectly. If you want to allow DBAL v4 to be installed in the constraint, go ahead and make a PR. |
Package
filament/filament
Package Version
v3.2.48
Laravel Version
v11.0.7
Livewire Version
No response
PHP Version
PHP 8.3
Problem description
Whilst updating to Laravel 11, I spotted a dependency oddity which seems accidental (though I'm not 100% sure). Here's a summary:
doctrine/dbal
from Filament, in line with Laravel 11: filamentphp/support@9f37568v3.2.50
release does not require this.I noticed this as it prevents upgrading Filament beyond v3.2.40 when used alongside
joelbutcher/socialstream
, a popular package with Filament integration, which requiresdoctrine/dbal v4.0
.I assume this is unintentional but may be misunderstanding how the subtree split works.
Expected behavior
doctrine/dbal
should not be required within the subtree split offilament/support
.Steps to reproduce
Try to install Filament alongside any project which requires
doctrine/dbal
v4 (e.g. https://github.com/joelbutcher/socialstream)Reproduction repository
https://github.com/joelbutcher/socialstream
Relevant log output
The text was updated successfully, but these errors were encountered: