simplify hidden check

coleshirley · coleshirley · commit 30a6bcdd1c49 · 2024-10-07T11:42:16.000-05:00
diff --git a/packages/forms/src/Components/Concerns/HasState.php b/packages/forms/src/Components/Concerns/HasState.php
@@ -192,11 +192,11 @@ public function dehydrateState(array &$state, bool $isDehydrated = true): void
             }
         }
 
-        foreach ($this->getChildComponentContainers(withHidden: true) as $container) {
-            if ($container->getParentComponent()?->isHiddenAndNotDehydrated()) {
-                continue;
-            }
+        if ($this->isHiddenAndNotDehydrated()) {
+            return;
+        }
 
+        foreach ($this->getChildComponentContainers(withHidden: true) as $container) {
             $container->dehydrateState($state, $isDehydrated);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -192,11 +192,11 @@ public function dehydrateState(array &$state, bool $isDehydrated = true): void`
`192`	`192`	`}`
`193`	`193`	`}`
`194`	`194`
`195`		`- foreach ($this->getChildComponentContainers(withHidden: true) as $container) {`
`196`		`- if ($container->getParentComponent()?->isHiddenAndNotDehydrated()) {`
`197`		`- continue;`
`198`		`- }`
	`195`	`+ if ($this->isHiddenAndNotDehydrated()) {`
	`196`	`+ return;`
	`197`	`+ }`
`199`	`198`
	`199`	`+ foreach ($this->getChildComponentContainers(withHidden: true) as $container) {`
`200`	`200`	`$container->dehydrateState($state, $isDehydrated);`
`201`	`201`	`}`
`202`	`202`	`}`