Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"downsample tiles" corrupts stitching #38

Open
aryehw opened this issue Aug 11, 2016 · 4 comments · May be fixed by #69
Open

"downsample tiles" corrupts stitching #38

aryehw opened this issue Aug 11, 2016 · 4 comments · May be fixed by #69

Comments

@aryehw
Copy link

aryehw commented Aug 11, 2016

When I select "downsample tiles", the stitching does something strange. It puts all of my grid of tiles in one row. When I do not down-sample, with all else the same, it works as expected. Do I misunderstand what the downsample option does? I was trying to use it to same space on a really large stitched image.

I attached a screenshot of the stitching parameters.
stitchingparameters

@ctrueden
Copy link
Member

ctrueden commented May 10, 2017

Apologies for the long delay in reply here. I guess I am ostensibly the one who has to support the downsampling feature, since a former LOCI programmer added it, and @StephanPreibisch knows basically nothing about it.

Do I misunderstand what the downsample option does?

Nope—it is supposed to simply save memory and processing power, by working on smaller versions of your tiles. It sounds like you probably found a bug.

I assume you never found a workaround, and that this is still a problem, so I leave the issue open. But I'm afraid I have no time to even attempt reproducing this bug, much less fixing it.

The good news is that @StephanPreibisch is on the cusp of releasing his next major iteration of the stitching plugin, which will maybe make this issue moot. Fingers crossed.

@lguerard
Copy link

Hi Curtis,

I'm also having issues with the downsampling option of this plugin so I'm guessing this has still not been resolved... More information available here.

It seems that reading the tile position from file messes up the downsample position somehow...

@ctrueden
Copy link
Member

@lguerard If you have time to investigate and file a PR, I would try to get it merged and released quickly. Unfortunately, I don't have time to work on it myself.

@lguerard
Copy link

@ctrueden I managed to have my issue fixed by changing just one line as you can see from #69

Was there a reason to only do the downsampling if GridType was 5 or 7 ?

@imagejan imagejan linked a pull request Oct 27, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants