Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing clone() method in typings #327

Open
gluck opened this issue Mar 27, 2025 · 0 comments
Open

Missing clone() method in typings #327

gluck opened this issue Mar 27, 2025 · 0 comments

Comments

@gluck
Copy link

gluck commented Mar 27, 2025 •
edited
Loading

SlideGridNode and InteractiveSlideElementNode both have a .clone() method in the API, but these are missing from the typings.

Particularly an issue because:

  • SceneNode no longer has clone() (breaking type checks)
  • if devs use if ('clone' in node) {...} to fix it, type checking will pass, but runtime may fail (because those nodes do have the clone method)
Image

Also typo in the toString(), should be InteractiveSlideElementNode ... and not InteractiveSlideNode ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gluck