Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate finding bookmarks from creating tree view #4

Open
volks73 opened this issue Nov 24, 2019 · 0 comments
Open

Separate finding bookmarks from creating tree view #4

volks73 opened this issue Nov 24, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@volks73
Copy link
Member

volks73 commented Nov 24, 2019

The Graveyard currently "locks" the tree view of the bookmarks every time a bookmark information change event occurs. This means every time a grave is created or destroyed and every time a zombie is created or destroyed or an undo of any of these actions occur, the Graveyard tree view is refreshed and locked. When the Graveyard is locked, it clears the tree and display a "Please Wait" message. This can be very distracting and cumbersome to use, but it is the implementation of the default bookmark manager.

The time sink appears to be searching and finding all of the bookmarks within a scope. I believe a better approach would be to separate the time consuming bookmark search from the tree view creation and possibly add a status message or icon at the top when the Graveyard is searching/refreshing the bookmarks.

First, the Update Bookmarks View case and sub-VI should be broken into two separate cases, "Update Bookmarks Data" and "Update Bookmarks View". The "Update Bookmarks Data" case and related sub-VI would search for all of the bookmarks and updated the "cache" or state data for the Graveyard with the new bookmarks from the search. Once this is done, then the front panel is locked out and the tree view is updated with the "Update Bookmarks View" case and sub-VI.

The searching for bookmarks will probably need to be placed in a separate loop from the Message and Event handler loops. A separate queue may also be needed. This way, the user can still interact with the Graveyard while it is searching for new bookmarks. The first attempt should just continue to display the tree "as-is" and only update/lock out the tree view within the same loop. Basically, do not clear the tree view will searching for bookmarks.

@volks73 volks73 self-assigned this Nov 24, 2019
@volks73 volks73 added the enhancement New feature or request label Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant