Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance of putting this wonderful app on F-Droid store? #11

Open
tinylucid opened this issue Dec 3, 2020 · 17 comments
Open

Any chance of putting this wonderful app on F-Droid store? #11

tinylucid opened this issue Dec 3, 2020 · 17 comments
Labels
enhancement New feature or request

Comments

@tinylucid
Copy link

I would really appreciate it (and I am sure many others).

@fibelatti
Copy link
Owner

Hi @defphil, thanks for the suggestion. I will look into doing it.

@fibelatti fibelatti added the enhancement New feature or request label Dec 3, 2020
@grrrrr
Copy link

grrrrr commented Feb 28, 2022

I'll second this request, it would be very useful to have on f-droid given that the other android app, pindroid has stalled in development

@grrrrr
Copy link

grrrrr commented Aug 15, 2023

Hi @fibelatti

If f-droid is not an options, would it be possible to release APK on gitbub? It might allow for inclusion with @IzzySoft's repo which can be used with f-droid https://apt.izzysoft.de/fdroid/

@IzzySoft
Copy link

Would fit from what I see – if the signed APK were available here (preferably with releases being tagged and the APK files attached to their corresponding release).

@fibelatti
Copy link
Owner

Hi @fibelatti

If f-droid is not an options, would it be possible to release APK on gitbub? It might allow for inclusion with @IzzySoft's repo which can be used with f-droid https://apt.izzysoft.de/fdroid/

Hey @grrrrr, thanks for suggesting this alternative, I know it's been a good while since adding the app to F-Droid was first suggested. I've looked into it a while back but never managed to go through the full setup required, so this alternative might facilitate things.

I still need to make a few changes to the app because I'm use some play services (to auto-update and prompt for app store reviews). I'll either have to remove those or build a different app flavour that's specific to F-Droid. I'll prioritise this and see what it takes to add it to the repo

@fibelatti
Copy link
Owner

@IzzySoft I have just released v2 which should be suitable for your repository. I have attached the signed .apk to the release on GitHub, is there anything else I should be doing to have it listed?

@IzzySoft
Copy link

I have just released v2 which should be suitable for your repository.

Confirmed: it is 😃

is there anything else I should be doing to have it listed?

Just to wait until it shows up here with the next sync around 6 pm UTC 😃 If you want to define how your app is presented, you could establish Fastlane structures here in your app's repo (be welcome to use my Fastlane Cheat Sheet for guidance with that). And of course you're also welcome to pick a badge to link to your app's new presence 😉

Thanks a lot!

@fibelatti
Copy link
Owner

@IzzySoft awesome, thank you! I'll look into setting up fastlane and adding a badge to the repository later today 🚀

@IzzySoft
Copy link

Fantastic! Please givve me a ping here once Fastlane is ready – so I cross-check, enable it on my end and (if you link me that RFP I saw a few hours again) also kick the issuebot for another scan at F-Droid.org 😉

@fibelatti
Copy link
Owner

fibelatti commented Aug 29, 2023

@IzzySoft I've setup the metadata for fastlane now and published a new release just in case since F-Droid doesn't build from HEAD. This new tag should also fix the Gradle wrapper issue from the RFP 👀

I'm gonna look into the badges next, thanks for your support

Edit: the Gradle wrapper changes messed up my GHA CI, so let me figure that out
Edit 2: it should be sorted now

@grrrrr
Copy link

grrrrr commented Aug 31, 2023

@fibelatti & @IzzySoft this is fantastic, thank you both for getting this available via f-droid clients.

@IzzySoft
Copy link

Oof, got no notification for the edits – so thanks @grrrrr for causing this ping 🙈 Bot is triggered now at the RFP.

@fibelatti
Copy link
Owner

@IzzySoft no problem! As always, thanks a mil for your support!

@fibelatti
Copy link
Owner

Hey @IzzySoft, I've got two questions and couldn't think of a better way to reach out!

  1. I have setup the metadata, could you please enable that on your side so that my listing on IzzyOnDroid is automatically updated?
  2. I'm about to include com.google.android.gms:play-services-oss-licenses as a dependency to help listing all other OSS libraries I've used. That's the dependency for this plugin and their license points to https://developer.android.com/studio/terms. Do you reckon that would be a problem for IzzyOnDroid/F-Droid because it's a Play Services dependency? If so I'd much rather find an alternative

@IzzySoft
Copy link

couldn't think of a better way to reach out!

Totally fine this way 😃

could you please enable that on your side

That was already done on 2023-10-02. Changes on your end would be pulled along with new releases.

I'm about to include com.google.android.gms:play-services-oss-licenses

Bad idea. The "oss" in that name is misleading: it only processes FOSS-licenses but is not fully FOSS itself (but will drag in proprietary dependencies like GMS) – those AS-terms are proprietary, too (limiting freedoms). So yes, I'd say that is a problem. Mind to pick one of the alternatives I've collected for you? 😉

@fibelatti
Copy link
Owner

@IzzySoft you're a gentleman sir! Thanks for enabling the metadata change and for linking the alternatives! I'll look into them before submitting the next update.

I've also released a new app this weekend but it already contains the play library so I'll remove it first before submitting it to IzzyOnDroid as well.

Thanks a mil Izzy!

@IzzySoft
Copy link

You are very welcome! Just give me a ping when your new app is ready. Don't be surprised if I then respond that it's already listed 🙈

Some background:

  • there's a quality check script running here once a month, a.o. checking if some repo has Fastlane added while it's not available here, or whether it is available on both ends but not fully enabled here. That's how your fastlane structures were already added in October: my tool reported it to me.
  • I have some other tool watching out for new apps on Codeberg, Gtihub, GitLab which are neither listed at F-Droid nor in my repo. That's how many apps come to my repo.
  • there are several more things automated here. Like, had you added that library, as soon as the new APK was pulled here an alert had popped up notifying me. That's e.g. how one app got removed from my repo today, for exceeding those thresholds by far (7 offending libraries is simply too much)

Not all is automated, though. So don't you worry I'd get bored – I won't 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants